Changeset 196336 in webkit

Timestamp:

Feb 9, 2016 2:16:14 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Expiration column in Storage tab can't be sorted
​https://bugs.webkit.org/show_bug.cgi?id=154043
<rdar://problem/24572272>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-09
Reviewed by Brian Burg.

• UserInterface/Views/CookieStorageContentView.js:

(WebInspector.CookieStorageContentView.prototype._sortDataGrid.expiresCompare):
Sort Session as the shortest time, not the longest time. Use the
cookie.expires date when sorting, not the locale string.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CookieStorageContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-02-09  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Expiration column in Storage tab can't be sorted
+        https://bugs.webkit.org/show_bug.cgi?id=154043
+        <rdar://problem/24572272>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/CookieStorageContentView.js:
+        (WebInspector.CookieStorageContentView.prototype._sortDataGrid.expiresCompare):
+        Sort Session as the shortest time, not the longest time. Use the
+        cookie.expires date when sorting, not the locale string.
+
 2016-02-09  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js

@@ -186 +186 @@
         {
             if (nodeA.cookie.session !== nodeB.cookie.session)
-                return nodeA.cookie.session ? 1 : -1;
+                return nodeA.cookie.session ? -1 : 1;
 
             if (nodeA.cookie.session)
                 return 0;
 
-            return nodeA.data["expires"] - nodeB.data["expires"];
+            return nodeA.cookie.expires - nodeB.cookie.expires;
         }