Changeset 196391 in webkit


Ignore:
Timestamp:
Feb 10, 2016 1:45:12 PM (8 years ago)
Author:
jer.noble@apple.com
Message:

[Mac] Graphical corruption in videos when enabling custom loading path
https://bugs.webkit.org/show_bug.cgi?id=154044

Reviewed by Alex Christensen.

Revert the "Drive-by fix" in r196345 as it breaks the WebCoreNSURLSessionTests.BasicOperation API test.

  • platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r196388 r196391  
     12016-02-10  Jer Noble  <jer.noble@apple.com>
     2
     3        [Mac] Graphical corruption in videos when enabling custom loading path
     4        https://bugs.webkit.org/show_bug.cgi?id=154044
     5
     6        Reviewed by Alex Christensen.
     7
     8        Revert the "Drive-by fix" in r196345 as it breaks the WebCoreNSURLSessionTests.BasicOperation API test.
     9
     10        * platform/network/cocoa/WebCoreNSURLSession.mm:
     11        (-[WebCoreNSURLSessionDataTask resource:receivedData:length:]):
     12
    1132016-02-10  Myles C. Maxfield  <mmaxfield@apple.com>
    214
  • trunk/Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm

    r196345 r196391  
    514514    // e.g., RetainPtr<CFDataRef> cfData = resource->resourceBuffer()->createCFData();
    515515
    516     self.countOfBytesReceived += length;
    517 
    518516    RetainPtr<NSData> nsData = adoptNS([[NSData alloc] initWithBytes:data length:length]);
    519517    RetainPtr<WebCoreNSURLSessionDataTask> strongSelf { self };
    520518    [self.session addDelegateOperation:[strongSelf, length, nsData] {
     519        strongSelf.get().countOfBytesReceived += length;
    521520        id<NSURLSessionDataDelegate> dataDelegate = (id<NSURLSessionDataDelegate>)strongSelf.get().session.delegate;
    522521        if ([dataDelegate respondsToSelector:@selector(URLSession:dataTask:didReceiveData:)])
Note: See TracChangeset for help on using the changeset viewer.