Changeset 196395 in webkit

Timestamp:

Feb 10, 2016 2:16:58 PM (8 years ago)

Author:

mark.lam@apple.com

Message:

WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture: should assert that it is being called from the "main" thread.
​https://bugs.webkit.org/show_bug.cgi?id=154059

Reviewed by Geoffrey Garen.

This makes it so that misbehaving clients which call it (indirectly) from another
thread (not the main thread) will fail faster. Otherwise, we get potential
memory corruption that results in strange crashes elsewhere later.

• WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):

Location:

trunk/Source/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebFrame.mm (modified) (1 diff)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2016-02-10  Mark Lam  <mark.lam@apple.com>
+
+        WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture: should assert that it is being called from the "main" thread.
+        https://bugs.webkit.org/show_bug.cgi?id=154059
+
+        Reviewed by Geoffrey Garen.
+
+        This makes it so that misbehaving clients which call it (indirectly) from another
+        thread (not the main thread) will fail faster.  Otherwise, we get potential
+        memory corruption that results in strange crashes elsewhere later.
+
+        * WebView/WebFrame.mm:
+        (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
+
 2016-02-04  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebFrame.mm

@@ -671 +671 @@
         return @"";
 
+    RELEASE_ASSERT(isMainThread());
+
     ASSERT(_private->coreFrame->document());
     RetainPtr<WebFrame> protect(self); // Executing arbitrary JavaScript can destroy the frame.