Changeset 196443 in webkit

Timestamp:

Feb 11, 2016 2:52:40 PM (8 years ago)

Author:

rniwa@webkit.org

Message:

AnalysisResultsViewer never uses this._smallerIsBetter
​https://bugs.webkit.org/show_bug.cgi?id=154134

Reviewed by Chris Dumez.

Removed the unused instance variable _smallerIsBetter from AnalysisResultsViewer and TestGroupStackingBlock.

• public/v3/components/analysis-results-viewer.js:

(AnalysisResultsViewer): Removed the unused _smallerIsBetter.
(AnalysisResultsViewer.prototype.setSmallerIsBetter): Deleted.
(AnalysisResultsViewer.prototype.buildRowGroups):
(AnalysisResultsViewer.TestGroupStackingBlock): Removed the unused _smallerIsBetter.

• public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage.prototype._didFetchTask):

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/v3/components/analysis-results-viewer.js (modified) (4 diffs)
• public/v3/pages/analysis-task-page.js (modified) (1 diff)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2016-02-11  Ryosuke Niwa  <rniwa@webkit.org>
+
+        AnalysisResultsViewer never uses this._smallerIsBetter
+        https://bugs.webkit.org/show_bug.cgi?id=154134
+
+        Reviewed by Chris Dumez.
+
+        Removed the unused instance variable _smallerIsBetter from AnalysisResultsViewer and TestGroupStackingBlock.
+
+        * public/v3/components/analysis-results-viewer.js:
+        (AnalysisResultsViewer): Removed the unused _smallerIsBetter.
+        (AnalysisResultsViewer.prototype.setSmallerIsBetter): Deleted.
+        (AnalysisResultsViewer.prototype.buildRowGroups):
+        (AnalysisResultsViewer.TestGroupStackingBlock): Removed the unused _smallerIsBetter.
+        * public/v3/pages/analysis-task-page.js:
+        (AnalysisTaskPage.prototype._didFetchTask):
+
 2016-02-11  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/perf.webkit.org/public/v3/components/analysis-results-viewer.js

@@ -4 +4 @@
     {
         super('analysis-results-viewer');
-        this._smallerIsBetter = false;
         this._startPoint = null;
         this._endPoint = null;
@@ -17 +16 @@
     setTestGroupCallback(callback) { this._testGroupCallback = callback; }
 
-    setSmallerIsBetter(smallerIsBetter)
-    {
-        this._smallerIsBetter = smallerIsBetter;
-        this._shouldRenderTable = true;
-    }
-
     setCurrentTestGroup(testGroup)
     {
@@ -105 +98 @@
                 if (!block) {
                     block = new AnalysisResultsViewer.TestGroupStackingBlock(
-                        testGroup, self._smallerIsBetter, self._classForTestGroup(testGroup), self._openStackingBlock.bind(self, testGroup));
+                        testGroup, self._classForTestGroup(testGroup), self._openStackingBlock.bind(self, testGroup));
                     testGroupLayoutMap.set(testGroup, block);
                 }
@@ -309 +302 @@
 
 AnalysisResultsViewer.TestGroupStackingBlock = class {
-    constructor(testGroup, smallerIsBetter, className, callback)
+    constructor(testGroup, className, callback)
     {
         this._testGroup = testGroup;
-        this._smallerIsBetter = smallerIsBetter;
         this._rootSetIndexRowIndexMap = [];
         this._className = className;

trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js

@@ -69 +69 @@
         var formatter = metric.makeFormatter(4);
         this._analysisResultsViewer.setValueFormatter(formatter);
-        this._analysisResultsViewer.setSmallerIsBetter(metric.isSmallerBetter());
         this._testGroupResultsTable.setValueFormatter(formatter);