Changeset 196568 in webkit
- Timestamp:
- Feb 14, 2016 8:43:54 PM (8 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 46 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r196567 r196568 1 2016-02-14 Chris Dumez <cdumez@apple.com> 2 3 Drop the [EventTarget] WebKit-specific IDL extended attribute 4 https://bugs.webkit.org/show_bug.cgi?id=154171 5 6 Reviewed by Sam Weinig. 7 8 Drop the [EventTarget] WebKit-specific IDL extended attribute now that 9 all interfaces inherit EventTarget when they should. 10 11 No new tests, no Web-Exposed behavior change. 12 13 * Modules/battery/BatteryManager.idl: 14 * Modules/encryptedmedia/MediaKeySession.idl: 15 * Modules/indexeddb/IDBDatabase.idl: 16 * Modules/indexeddb/IDBOpenDBRequest.idl: 17 * Modules/indexeddb/IDBRequest.idl: 18 * Modules/indexeddb/IDBTransaction.idl: 19 * Modules/mediasession/MediaRemoteControls.idl: 20 * Modules/mediasource/MediaSource.idl: 21 * Modules/mediasource/SourceBuffer.idl: 22 * Modules/mediasource/SourceBufferList.idl: 23 * Modules/mediastream/MediaStream.idl: 24 * Modules/mediastream/MediaStreamTrack.idl: 25 * Modules/mediastream/RTCDTMFSender.idl: 26 * Modules/mediastream/RTCDataChannel.idl: 27 * Modules/mediastream/RTCPeerConnection.idl: 28 * Modules/notifications/Notification.idl: 29 * Modules/speech/SpeechSynthesisUtterance.idl: 30 * Modules/webaudio/AudioContext.idl: 31 * Modules/webaudio/AudioNode.idl: 32 * Modules/webaudio/OfflineAudioContext.idl: 33 * Modules/websockets/WebSocket.idl: 34 * bindings/scripts/CodeGeneratorGObject.pm: 35 (ImplementsInterface): 36 (SkipFunction): Deleted. 37 (GenerateCFile): Deleted. 38 * bindings/scripts/CodeGeneratorJS.pm: 39 (InstanceNeedsVisitChildren): 40 (GenerateImplementation): 41 * bindings/scripts/IDLAttributes.txt: 42 * bindings/scripts/test/TestEventTarget.idl: 43 * bindings/scripts/test/TestNode.idl: 44 * css/FontLoader.idl: 45 * dom/EventTarget.idl: 46 * dom/MessagePort.idl: 47 * dom/Node.idl: 48 * dom/WebKitNamedFlow.idl: 49 * fileapi/FileReader.idl: 50 * html/MediaController.idl: 51 * html/track/AudioTrackList.idl: 52 * html/track/TextTrack.idl: 53 * html/track/TextTrackCue.idl: 54 * html/track/TextTrackList.idl: 55 * html/track/VideoTrackList.idl: 56 * loader/appcache/DOMApplicationCache.idl: 57 * page/DOMWindow.idl: 58 * page/EventSource.idl: 59 * page/Performance.idl: 60 * workers/WorkerGlobalScope.idl: 61 * xml/XMLHttpRequest.idl: 62 * xml/XMLHttpRequestUpload.idl: 63 1 64 2016-02-14 Chris Dumez <cdumez@apple.com> 2 65 -
trunk/Source/WebCore/Modules/battery/BatteryManager.idl
r196466 r196568 23 23 Conditional=BATTERY_STATUS, 24 24 ActiveDOMObject, 25 EventTarget,26 25 ] interface BatteryManager : EventTarget { 27 26 readonly attribute boolean charging; -
trunk/Source/WebCore/Modules/encryptedmedia/MediaKeySession.idl
r196466 r196568 26 26 [ 27 27 Conditional=ENCRYPTED_MEDIA_V2, 28 EventTarget,29 28 InterfaceName=WebKitMediaKeySession, 30 29 ActiveDOMObject, -
trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.idl
r196466 r196568 28 28 Conditional=INDEXED_DATABASE, 29 29 ActiveDOMObject, 30 EventTarget,31 30 EnabledAtRuntime=IndexedDB, 32 31 SkipVTableValidation, -
trunk/Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.idl
r189746 r196568 26 26 [ 27 27 Conditional=INDEXED_DATABASE, 28 EventTarget,29 28 JSGenerateToJSObject, 30 29 JSGenerateToNativeObject, -
trunk/Source/WebCore/Modules/indexeddb/IDBRequest.idl
r196466 r196568 32 32 EnabledAtRuntime=IndexedDB, 33 33 ActiveDOMObject, 34 EventTarget,35 34 SkipVTableValidation, 36 35 GenerateIsReachable=Impl, -
trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.idl
r196466 r196568 28 28 Conditional=INDEXED_DATABASE, 29 29 ActiveDOMObject, 30 EventTarget,31 30 EnabledAtRuntime=IndexedDB, 32 31 SkipVTableValidation, -
trunk/Source/WebCore/Modules/mediasession/MediaRemoteControls.idl
r196466 r196568 28 28 Constructor, 29 29 ConstructorCallWith=ScriptExecutionContext, 30 EventTarget,31 30 ] interface MediaRemoteControls : EventTarget { 32 31 attribute boolean previousTrackEnabled; -
trunk/Source/WebCore/Modules/mediasource/MediaSource.idl
r196466 r196568 37 37 Conditional=MEDIA_SOURCE, 38 38 ActiveDOMObject, 39 EventTarget,40 39 EnabledBySetting=MediaSource, 41 40 Constructor, -
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.idl
r196466 r196568 38 38 NoInterfaceObject, 39 39 ActiveDOMObject, 40 EventTarget,41 40 ] interface SourceBuffer : EventTarget { 42 41 -
trunk/Source/WebCore/Modules/mediasource/SourceBufferList.idl
r196466 r196568 32 32 Conditional=MEDIA_SOURCE, 33 33 NoInterfaceObject, 34 EventTarget,35 34 GenerateIsReachable=Impl, 36 35 CallWith=ScriptExecutionContext, -
trunk/Source/WebCore/Modules/mediastream/MediaStream.idl
r196466 r196568 25 25 [ 26 26 Conditional=MEDIA_STREAM, 27 EventTarget,28 27 Constructor, 29 28 Constructor(MediaStream stream), -
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl
r196466 r196568 28 28 [ 29 29 Conditional=MEDIA_STREAM, 30 EventTarget,31 30 ActiveDOMObject, 32 31 SkipVTableValidation, -
trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.idl
r196466 r196568 28 28 Conditional=MEDIA_STREAM, 29 29 ActiveDOMObject, 30 EventTarget,31 30 ] interface RTCDTMFSender : EventTarget { 32 31 readonly attribute boolean canInsertDTMF; -
trunk/Source/WebCore/Modules/mediastream/RTCDataChannel.idl
r196466 r196568 26 26 NoInterfaceObject, 27 27 Conditional=MEDIA_STREAM, 28 EventTarget,29 28 ] interface RTCDataChannel : EventTarget { 30 29 readonly attribute DOMString label; -
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl
r196466 r196568 37 37 ConstructorCallWith=ScriptExecutionContext, 38 38 ConstructorRaisesException, 39 EventTarget,40 39 InterfaceName=webkitRTCPeerConnection, 41 40 ] interface RTCPeerConnection : EventTarget { -
trunk/Source/WebCore/Modules/notifications/Notification.idl
r196466 r196568 33 33 Conditional=NOTIFICATIONS|LEGACY_NOTIFICATIONS, 34 34 ActiveDOMObject, 35 EventTarget,36 35 #if defined(ENABLE_NOTIFICATIONS) && ENABLE_NOTIFICATIONS 37 36 Constructor(DOMString title, [Default=Undefined] optional Dictionary options), -
trunk/Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl
r196476 r196568 26 26 [ 27 27 Conditional=SPEECH_SYNTHESIS, 28 EventTarget,29 28 ConstructorCallWith=ScriptExecutionContext, 30 29 Constructor([Default=NullString] optional DOMString text) -
trunk/Source/WebCore/Modules/webaudio/AudioContext.idl
r196466 r196568 36 36 ActiveDOMObject, 37 37 CustomConstructor, 38 EventTarget,39 38 InterfaceName=webkitAudioContext, 40 39 ] interface AudioContext : EventTarget { -
trunk/Source/WebCore/Modules/webaudio/AudioNode.idl
r196466 r196568 26 26 Conditional=WEB_AUDIO, 27 27 GenerateIsReachable=Impl, 28 EventTarget,29 28 ] interface AudioNode : EventTarget { 30 29 readonly attribute AudioContext context; -
trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl
r168302 r196568 25 25 [ 26 26 Conditional=WEB_AUDIO, 27 EventTarget,28 27 JSGenerateToJSObject, 29 28 Constructor(unsigned long numberOfChannels, unsigned long numberOfFrames, unrestricted float sampleRate), -
trunk/Source/WebCore/Modules/websockets/WebSocket.idl
r196466 r196568 39 39 ConstructorRaisesException, 40 40 ConstructorCallWith=ScriptExecutionContext, 41 EventTarget,42 41 ] interface WebSocket : EventTarget { 43 42 readonly attribute DOMString URL; // Lowercased .url is the one in the spec, but leaving .URL for compatibility reasons. -
trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
r196520 r196568 333 333 # This is for DataTransferItemList.idl add(File) method 334 334 if ($functionName eq "webkit_dom_data_transfer_item_list_add" && @{$function->parameters} == 1) { 335 return 1;336 }337 338 # Skip dispatch_event methods.339 # FIXME: This can be removed once all classes implementing EventTarget inherit from it instead.340 if ($parentNode->extendedAttributes->{"EventTarget"} && $function->signature->name eq "dispatchEvent") {341 335 return 1; 342 336 } … … 1506 1500 my $implementInterface = shift; 1507 1501 1508 # FIXME: Check only the parent class once all classes implementing EventTarget inherit from it instead. 1509 return 1 if $interface->parent and $interface->parent eq implementInterface and ShouldBeExposedAsInterface($interface->parent); 1510 return 1 if $interface->extendedAttributes->{$implementInterface}; 1511 return 0; 1502 return $codeGenerator->InheritsInterface($interface, $implementInterface); 1512 1503 } 1513 1504 -
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
r196563 r196568 812 812 my $interface = shift; 813 813 return $interface->extendedAttributes->{"JSCustomMarkFunction"} 814 || $ interface->extendedAttributes->{"EventTarget"}814 || $codeGenerator->InheritsInterface($interface, "EventTarget") 815 815 || $interface->name eq "EventTarget" 816 816 || $interface->extendedAttributes->{"ReportExtraMemoryCost"} … … 1762 1762 my $parentClassName = GetParentClassName($interface); 1763 1763 my $visibleInterfaceName = $codeGenerator->GetVisibleInterfaceName($interface); 1764 my $eventTarget = $ interface->extendedAttributes->{"EventTarget"} || ($codeGenerator->InheritsInterface($interface, "EventTarget") && $interface->name ne "EventTarget");1764 my $eventTarget = $codeGenerator->InheritsInterface($interface, "EventTarget") && $interface->name ne "EventTarget"; 1765 1765 my $needsVisitChildren = InstanceNeedsVisitChildren($interface); 1766 1766 … … 2997 2997 push(@implContent, " ASSERT_GC_OBJECT_INHERITS(thisObject, info());\n"); 2998 2998 push(@implContent, " Base::visitChildren(thisObject, visitor);\n"); 2999 if ($ interface->extendedAttributes->{"EventTarget"} || $interface->name eq "EventTarget") {2999 if ($codeGenerator->InheritsInterface($interface, "EventTarget")) { 3000 3000 push(@implContent, " thisObject->wrapped().visitJSEventListeners(visitor);\n"); 3001 3001 } … … 3047 3047 push(@implContent, " return true;\n"); 3048 3048 } 3049 if ($codeGenerator->Inherits ExtendedAttribute($interface, "EventTarget")) {3049 if ($codeGenerator->InheritsInterface($interface, "EventTarget")) { 3050 3050 if (!$emittedJSCast) { 3051 3051 push(@implContent, " auto* js${interfaceName} = jsCast<JS${interfaceName}*>(handle.slot()->asCell());\n"); -
trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt
r196303 r196568 62 62 EnabledBySetting=* 63 63 EnforceRange 64 EventTarget65 64 ForwardDeclareInHeader 66 65 GenerateIsReachable=|Impl|ImplWebGLRenderingContext|ImplDocument|ImplElementRoot|ImplFrame|ImplOwnerNodeRoot -
trunk/Source/WebCore/bindings/scripts/test/TestEventTarget.idl
r196466 r196568 28 28 29 29 [ 30 EventTarget,31 30 MasqueradesAsUndefined 32 31 ] interface TestEventTarget : EventTarget { -
trunk/Source/WebCore/bindings/scripts/test/TestNode.idl
r190023 r196568 20 20 21 21 [ 22 EventTarget,23 22 Constructor, 24 23 ] interface TestNode : Node { -
trunk/Source/WebCore/css/FontLoader.idl
r196466 r196568 33 33 Conditional=FONT_LOAD_EVENTS, 34 34 ActiveDOMObject, 35 EventTarget,36 35 GenerateIsReachable=ImplDocument, 37 36 ] interface FontLoader : EventTarget { -
trunk/Source/WebCore/dom/EventTarget.idl
r196563 r196568 25 25 CustomToJSObject, 26 26 JSCustomToNativeObject, 27 EventTarget,28 27 JSCustomHeader, 29 28 ] interface EventTarget { -
trunk/Source/WebCore/dom/MessagePort.idl
r196466 r196568 30 30 GenerateIsReachable=Impl, 31 31 ActiveDOMObject, 32 EventTarget,33 32 ] interface MessagePort : EventTarget { 34 33 // We need to have something as an ObjC binding, because MessagePort is used in MessageEvent, which already has one, -
trunk/Source/WebCore/dom/Node.idl
r196466 r196568 25 25 CustomIsReachable, 26 26 CustomToJSObject, 27 EventTarget,28 27 ObjCPolymorphic, 29 28 ] interface Node -
trunk/Source/WebCore/dom/WebKitNamedFlow.idl
r196476 r196568 30 30 [ 31 31 NoInterfaceObject, 32 EventTarget,33 32 GenerateIsReachable=ImplOwnerNodeRoot, 34 33 ] interface WebKitNamedFlow : EventTarget -
trunk/Source/WebCore/fileapi/FileReader.idl
r196466 r196568 35 35 Constructor, 36 36 ConstructorCallWith=ScriptExecutionContext, 37 EventTarget,38 37 ] interface FileReader : EventTarget { 39 38 // ready states -
trunk/Source/WebCore/html/MediaController.idl
r196466 r196568 28 28 Constructor, 29 29 ConstructorCallWith=ScriptExecutionContext, 30 EventTarget,31 30 ] interface MediaController : EventTarget { 32 31 readonly attribute TimeRanges buffered; -
trunk/Source/WebCore/html/track/AudioTrackList.idl
r196466 r196568 28 28 Conditional=VIDEO_TRACK, 29 29 GenerateIsReachable=ImplElementRoot, 30 EventTarget,31 30 JSCustomMarkFunction, 32 31 ] interface AudioTrackList : EventTarget { -
trunk/Source/WebCore/html/track/TextTrack.idl
r196466 r196568 29 29 [ 30 30 Conditional=VIDEO_TRACK, 31 EventTarget,32 31 GenerateIsReachable=ImplElementRoot, 33 32 JSCustomMarkFunction, -
trunk/Source/WebCore/html/track/TextTrackCue.idl
r196466 r196568 28 28 Constructor(unrestricted double startTime, unrestricted double endTime, DOMString text), 29 29 ConstructorCallWith=ScriptExecutionContext, 30 EventTarget,31 30 JSCustomMarkFunction, 32 31 CustomIsReachable, -
trunk/Source/WebCore/html/track/TextTrackList.idl
r196466 r196568 27 27 Conditional=VIDEO_TRACK, 28 28 GenerateIsReachable=ImplElementRoot, 29 EventTarget,30 29 JSCustomMarkFunction, 31 30 ] interface TextTrackList : EventTarget { -
trunk/Source/WebCore/html/track/VideoTrackList.idl
r196466 r196568 28 28 Conditional=VIDEO_TRACK, 29 29 GenerateIsReachable=ImplElementRoot, 30 EventTarget,31 30 JSCustomMarkFunction, 32 31 ] interface VideoTrackList : EventTarget { -
trunk/Source/WebCore/loader/appcache/DOMApplicationCache.idl
r196466 r196568 25 25 26 26 [ 27 EventTarget,28 27 DoNotCheckConstants, 29 28 GenerateIsReachable=ImplFrame, -
trunk/Source/WebCore/page/DOMWindow.idl
r196563 r196568 36 36 JSCustomToNativeObject, 37 37 CustomPutFunction, 38 EventTarget,39 38 JSLegacyParent=JSDOMWindowBase, 40 39 InterfaceName=Window, -
trunk/Source/WebCore/page/EventSource.idl
r196466 r196568 36 36 ConstructorCallWith=ScriptExecutionContext, 37 37 ConstructorRaisesException, 38 EventTarget,39 38 ] interface EventSource : EventTarget { 40 39 -
trunk/Source/WebCore/page/Performance.idl
r196466 r196568 33 33 [ 34 34 Conditional=WEB_TIMING, 35 EventTarget,36 35 ] interface Performance : EventTarget { 37 36 readonly attribute PerformanceNavigation navigation; -
trunk/Source/WebCore/workers/WorkerGlobalScope.idl
r196563 r196568 30 30 JSCustomMarkFunction, 31 31 JSCustomGetOwnPropertySlotAndDescriptor, 32 EventTarget,33 32 JSLegacyParent=JSWorkerGlobalScopeBase, 34 33 ] interface WorkerGlobalScope : EventTarget { -
trunk/Source/WebCore/xml/XMLHttpRequest.idl
r196466 r196568 42 42 ConstructorCallWith=ScriptExecutionContext, 43 43 JSCustomMarkFunction, 44 EventTarget,45 44 ] interface XMLHttpRequest : EventTarget { 46 45 // From XMLHttpRequestEventTarget -
trunk/Source/WebCore/xml/XMLHttpRequestUpload.idl
r196466 r196568 29 29 [ 30 30 GenerateIsReachable=Impl, 31 EventTarget,32 31 ] interface XMLHttpRequestUpload : EventTarget { 33 32 // From XMLHttpRequestEventTarget
Note: See TracChangeset
for help on using the changeset viewer.