Changeset 196631 in webkit

Timestamp:

Feb 16, 2016 1:45:41 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

Mouse cursor doesn't change when entering scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=154243

Reviewed by Simon Fraser.

If the scrollbar is over or very close to text or a link, when
entering the scrollbar the cursor is not changed, keeping the beam
or hand cursor when using the scrollbar. Same happens for image
documents where the magnifier cursor is used and it remains when
entering the scrollbars. We should use pointer cursor always for
scrollbars.

• page/EventHandler.cpp:

(WebCore::EventHandler::updateCursor): Request also to include
frame scrollbars in hit test result.
(WebCore::EventHandler::selectCursor): Use always pointer cursor
for scrollbars.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/EventHandler.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Mouse cursor doesn't change when entering scrollbars
+        https://bugs.webkit.org/show_bug.cgi?id=154243
+
+        Reviewed by Simon Fraser.
+
+        If the scrollbar is over or very close to text or a link, when
+        entering the scrollbar the cursor is not changed, keeping the beam
+        or hand cursor when using the scrollbar. Same happens for image
+        documents where the magnifier cursor is used and it remains when
+        entering the scrollbars. We should use pointer cursor always for
+        scrollbars.
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::updateCursor): Request also to include
+        frame scrollbars in hit test result.
+        (WebCore::EventHandler::selectCursor): Use always pointer cursor
+        for scrollbars.
+
 2016-02-15  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/page/EventHandler.cpp

@@ -1339 +1339 @@
     PlatformKeyboardEvent::getCurrentModifierState(shiftKey, ctrlKey, altKey, metaKey);
 
-    HitTestRequest request(HitTestRequest::ReadOnly);
+    HitTestRequest request(HitTestRequest::ReadOnly | HitTestRequest::AllowFrameScrollbars);
     HitTestResult result(view->windowToContents(m_lastKnownMousePosition));
     renderView->hitTest(request, result);
@@ -1362 +1362 @@
         return NoCursorChange;
 #endif
+
+    // Use always pointer cursor for scrollbars.
+    if (result.scrollbar()) {
+#if ENABLE(CURSOR_VISIBILITY)
+        cancelAutoHideCursorTimer();
+#endif
+        return pointerCursor();
+    }
 
     Node* node = result.targetNode();