Changeset 196741 in webkit

Timestamp:

Feb 17, 2016 9:27:31 PM (8 years ago)

Author:

Nikita Vasilyev

Message:

REGRESSION (r196620): Web Inspector: When the scrollbars are always visible, the console prompt is 1px taller
​https://bugs.webkit.org/show_bug.cgi?id=154328
<rdar://problem/24692996>

Introduce a CSS variable to ensure that the quick console is the
same height as the bottom right section of the styles sidebar.

Reviewed by Timothy Hatcher.

• UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ .options-container):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container):

• UserInterface/Views/QuickConsole.css:

(.quick-console):

• UserInterface/Views/Variables.css:

(:root):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CSSStyleDetailsSidebarPanel.css (modified) (2 diffs)
• UserInterface/Views/QuickConsole.css (modified) (1 diff)
• UserInterface/Views/Variables.css (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-02-17  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        REGRESSION (r196620): Web Inspector: When the scrollbars are always visible, the console prompt is 1px taller
+        https://bugs.webkit.org/show_bug.cgi?id=154328
+        <rdar://problem/24692996>
+
+        Introduce a CSS variable to ensure that the quick console is the
+        same height as the bottom right section of the styles sidebar.
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
+        (.sidebar > .panel.details.css-style > .content ~ .options-container):
+        (.sidebar > .panel.details.css-style > .content ~ .class-list-container):
+        * UserInterface/Views/QuickConsole.css:
+        (.quick-console):
+        * UserInterface/Views/Variables.css:
+        (:root):
+
 2016-02-17  Devin Rousso  <dcrousso+webkit@gmail.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css

@@ -77 +77 @@
 .sidebar > .panel.details.css-style > .content ~ .options-container {
     bottom: 0;
-    height: 29px;
+    height: var(--console-prompt-min-height);
 }
 
@@ -124 +124 @@
 .sidebar > .panel.details.css-style > .content ~ .class-list-container {
     flex-wrap: wrap;
-    bottom: 29px;
+    bottom: var(--console-prompt-min-height);
     max-height: 65px;
     padding: 3px 2px;

trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.css

@@ -26 +26 @@
 .quick-console {
     position: relative;
+    min-height: var(--console-prompt-min-height);
 
     display: flex;

trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css

@@ -37 +37 @@
 
     --console-secondary-text-color: hsla(0, 0%, 0%, 0.33);
+    --console-prompt-min-height: 30px;
 
     --syntax-highlight-number-color: hsl(248, 100%, 40%);