Changeset 196742 in webkit

Timestamp:

Feb 17, 2016 9:44:10 PM (8 years ago)

Author:

Chris Dumez

Message:

Regression(r196648): ​http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test
​https://bugs.webkit.org/show_bug.cgi?id=154357

Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

Rebaseline now that more checks are passing.

• web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Make location.assign() / location.replace()'s parameter mandatory,
as per the specification:
​https://html.spec.whatwg.org/multipage/browsers.html#the-location-interface

Previously, calling location.assign() / location.replace() without
parameter would be identical to calling location.assign("undefined") /
location.replace("undefined"), which is not useful.

After r196648, ​http://w3c-test.org/html/dom/interfaces.html was able to
test location.assign() / location.replace() further because they are now
on the instance (where they should be) instead of the prototype. One of
these tests calls these functions without parameter, expecting them to
throw an exception. However, in WebKit, it would not throw and it would
redirect us to ​http://w3c-test.org/html/dom/undefined.

Firefox and Chrome both follow the specification already and throw in
this case.

No new tests, already covered by existing test.

• page/Location.idl:

Make location.assign() / location.replace()'s parameter mandatory,
as per the specification.

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/Location.idl (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2016-02-17  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r196648): http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test
+        https://bugs.webkit.org/show_bug.cgi?id=154357
+
+        Reviewed by Alexey Proskuryakov.
+
+        Rebaseline now that more checks are passing.
+
+        * web-platform-tests/html/dom/interfaces-expected.txt:
+
 2016-02-17  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt

@@ -4148 +4148 @@
 PASS Location interface: window.location must have own property "hash" 
 FAIL Location interface: window.location must have own property "assign" assert_equals: property should be writable if and only if not unforgeable expected false but got true
-FAIL Location interface: calling assign(USVString) on window.location with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
-    [native code]
-}" did not throw
+PASS Location interface: calling assign(USVString) on window.location with too few arguments must throw TypeError 
 FAIL Location interface: window.location must have own property "replace" assert_equals: property should be writable if and only if not unforgeable expected false but got true
-FAIL Location interface: calling replace(USVString) on window.location with too few arguments must throw TypeError assert_throws: Called with 0 arguments function "function () {
-    [native code]
-}" did not throw
+PASS Location interface: calling replace(USVString) on window.location with too few arguments must throw TypeError 
 FAIL Location interface: window.location must have own property "reload" assert_equals: property should be writable if and only if not unforgeable expected false but got true
 PASS Location interface: window.location must have own property "ancestorOrigins" 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-02-17  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r196648): http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test
+        https://bugs.webkit.org/show_bug.cgi?id=154357
+
+        Reviewed by Alexey Proskuryakov.
+
+        Make location.assign() / location.replace()'s parameter mandatory,
+        as per the specification:
+        https://html.spec.whatwg.org/multipage/browsers.html#the-location-interface
+
+        Previously, calling location.assign() / location.replace() without
+        parameter would be identical to calling location.assign("undefined") /
+        location.replace("undefined"), which is not useful.
+
+        After r196648, http://w3c-test.org/html/dom/interfaces.html was able to
+        test location.assign() / location.replace() further because they are now
+        on the instance (where they should be) instead of the prototype. One of
+        these tests calls these functions without parameter, expecting them to
+        throw an exception. However, in WebKit, it would not throw and it would
+        redirect us to http://w3c-test.org/html/dom/undefined.
+
+        Firefox and Chrome both follow the specification already and throw in
+        this case.
+
+        No new tests, already covered by existing test.
+
+        * page/Location.idl:
+        Make location.assign() / location.replace()'s parameter mandatory,
+        as per the specification.
+
 2016-02-17  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/page/Location.idl

@@ -40 +40 @@
     [SetterCallWith=ActiveWindow&FirstWindow] attribute DOMString href;
 
-    [CallWith=ActiveWindow&FirstWindow, ForwardDeclareInHeader] void assign([Default=Undefined] optional DOMString url);
-    [CallWith=ActiveWindow&FirstWindow, ForwardDeclareInHeader] void replace([Default=Undefined] optional DOMString url);
+    [CallWith=ActiveWindow&FirstWindow, ForwardDeclareInHeader] void assign(DOMString url);
+    [CallWith=ActiveWindow&FirstWindow, ForwardDeclareInHeader] void replace(DOMString url);
     [CallWith=ActiveWindow, ForwardDeclareInHeader] void reload();