Changeset 196767 in webkit

Timestamp:

Feb 18, 2016 11:06:50 AM (8 years ago)

Author:

ChangSeok Oh

Message:

[GTK][Threaded Compositor] The web inspector doesn't work when using the threaded compositor
​https://bugs.webkit.org/show_bug.cgi?id=154067

Reviewed by Carlos Garcia Campos.

The forceCompositingMode should be true for threaded compositor. We set it true for a normal webView
in _WebKitSettingsPrivate() but we do not for inspector anywhere. So DrawingArea is not
properly created for the inspector. Let's move the setting to WebPreferences::platformInitializeStore
which is a common place for the webView and the inspector.

• UIProcess/API/gtk/WebKitSettings.cpp:

(_WebKitSettingsPrivate::_WebKitSettingsPrivate): Deleted.

• UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformInitializeStore):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitSettings.cpp (modified) (1 diff)
• UIProcess/gtk/WebPreferencesGtk.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-02-18  ChangSeok Oh  <changseok.oh@collabora.com>
+
+        [GTK][Threaded Compositor] The web inspector doesn't work when using the threaded compositor
+        https://bugs.webkit.org/show_bug.cgi?id=154067
+
+        Reviewed by Carlos Garcia Campos.
+
+        The forceCompositingMode should be true for threaded compositor. We set it true for a normal webView
+        in _WebKitSettingsPrivate() but we do not for inspector anywhere. So DrawingArea is not
+        properly created for the inspector. Let's move the setting to WebPreferences::platformInitializeStore
+        which is a common place for the webView and the inspector.
+
+        * UIProcess/API/gtk/WebKitSettings.cpp:
+        (_WebKitSettingsPrivate::_WebKitSettingsPrivate): Deleted.
+        * UIProcess/gtk/WebPreferencesGtk.cpp:
+        (WebKit::WebPreferences::platformInitializeStore):
+
 2016-02-18  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp

@@ -59 +59 @@
         pictographFontFamily = preferences->pictographFontFamily().utf8();
         defaultCharset = preferences->defaultTextEncodingName().utf8();
-
-#if USE(COORDINATED_GRAPHICS_THREADED)
-        preferences->setForceCompositingMode(true);
-#endif
     }
 

trunk/Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp

@@ -41 +41 @@
         setAcceleratedCompositingEnabled(false);
     }
+#endif
+#if USE(COORDINATED_GRAPHICS_THREADED)
+    setForceCompositingMode(true);
 #endif
 #if !ENABLE(OPENGL)