Changeset 197149 in webkit

Timestamp:

Feb 25, 2016 5:00:24 PM (8 years ago)

Author:

ddkilzer@apple.com

Message:

Change ASSERT to RELEASE_ASSERT in SOFT_LINK_CLASS() macro

Follow-up fix noted by Andy Estes for:

[Cocoa] Always check the return value of dlopen() and dlsym() in Release builds
<​http://webkit.org/b/154364>

• platform/mac/SoftLinking.h:

(SOFT_LINK_CLASS): Change ASSERT to RELEASE_ASSERT to check the
return value of objc_getClass(). This matches what we do for
SOFT_LINK_CLASS_FOR_SOURCE().

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/SoftLinking.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-02-25  David Kilzer  <ddkilzer@apple.com>
+
+        Change ASSERT to RELEASE_ASSERT in SOFT_LINK_CLASS() macro
+
+        Follow-up fix noted by Andy Estes for:
+
+            [Cocoa] Always check the return value of dlopen() and dlsym() in Release builds
+            <http://webkit.org/b/154364>
+
+        * platform/mac/SoftLinking.h:
+        (SOFT_LINK_CLASS): Change ASSERT to RELEASE_ASSERT to check the
+        return value of objc_getClass().  This matches what we do for
+        SOFT_LINK_CLASS_FOR_SOURCE().
+
 2016-02-25  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebCore/platform/mac/SoftLinking.h

@@ -175 +175 @@
         framework##Library(); \
         class##className = objc_getClass(#className); \
-        ASSERT(class##className); \
+        RELEASE_ASSERT(class##className); \
         get##className##Class = className##Function; \
         return class##className; \