Changeset 19716 in webkit


Ignore:
Timestamp:
Feb 19, 2007 5:22:06 PM (17 years ago)
Author:
weinig
Message:

LayoutTests:

Reviewed by Darin.

  1. Test for background image with relative url, when base url element is present. .html has a base url, which according to the html spec is supposed to be absolute, is actually a relative url. Absolute url would not work with ​file:// scheme.
  2. Test for base element and @import with relative url. ​http://bugs.webkit.org/show_bug.cgi?id=12214


  • fast/css/background-image-with-baseurl-expected.checksum: Added.
  • fast/css/background-image-with-baseurl-expected.png: Added.
  • fast/css/background-image-with-baseurl-expected.txt: Added.
  • fast/css/background-image-with-baseurl.html: Added.
  • fast/css/import_with_baseurl-expected.checksum: Added.
  • fast/css/import_with_baseurl-expected.png: Added.
  • fast/css/import_with_baseurl-expected.txt: Added.
  • fast/css/import_with_baseurl.html: Added.
  • fast/css/resources/background_image.css: Added.

WebCore:

Reviewed by Darin.

Update stylesheet href, when document's baseUrl changes. It needs
update when the stylesheet is constructed before the parser hits the base tag.
​http://bugs.webkit.org/show_bug.cgi?id=12214

  • css/StyleSheet.h: (WebCore::StyleSheet::setHref):
  • dom/Document.cpp: (WebCore::Document::setBaseURL):
  • dom/Document.h:
Location:
trunk
Files:
9 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r19707 r19716  
     12007-02-19  Zalan Bujtas  <zbujtas@gmail.com>
     2
     3        Reviewed by Darin.
     4
     5        1. Test for background image with relative url, when base url element
     6        is present. .html has a base url, which according to the html spec is supposed
     7        to be absolute, is actually a relative url. Absolute url would not work with file:// scheme.
     8        2. Test for base element and @import with relative url.
     9        http://bugs.webkit.org/show_bug.cgi?id=12214
     10       
     11        * fast/css/background-image-with-baseurl-expected.checksum: Added.
     12        * fast/css/background-image-with-baseurl-expected.png: Added.
     13        * fast/css/background-image-with-baseurl-expected.txt: Added.
     14        * fast/css/background-image-with-baseurl.html: Added.
     15        * fast/css/import_with_baseurl-expected.checksum: Added.
     16        * fast/css/import_with_baseurl-expected.png: Added.
     17        * fast/css/import_with_baseurl-expected.txt: Added.
     18        * fast/css/import_with_baseurl.html: Added.
     19        * fast/css/resources/background_image.css: Added.
     20
    1212007-02-19  Antti Koivisto  <antti@apple.com>
    222

  • trunk/WebCore/ChangeLog

    r19715 r19716  
     12007-02-19  Zalan Bujtas  <zbujtas@gmail.com>
     2
     3        Reviewed by Darin.
     4
     5        Update stylesheet href, when document's baseUrl changes. It needs
     6        update when the stylesheet is constructed before the parser hits the base tag.
     7        http://bugs.webkit.org/show_bug.cgi?id=12214
     8
     9        * css/StyleSheet.h:
     10        (WebCore::StyleSheet::setHref):
     11        * dom/Document.cpp:
     12        (WebCore::Document::setBaseURL):
     13        * dom/Document.h:
     14
    1152007-02-19  Mitz Pettel  <mitz@webkit.org>
    216

  • trunk/WebCore/css/StyleSheet.h

    r18874 r19716  
    5050    StyleSheet *parentStyleSheet() const;
    5151    String href() const { return m_strHref; }
     52    void setHref(const String& href) { m_strHref = href; }
    5253    String title() const { return m_strTitle; }
    5354    void setTitle(const String& s) { m_strTitle = s; }

  • trunk/WebCore/dom/Document.cpp

    r19691 r19716  
    15191519}
    15201520
     1521void Document::setBaseURL(const DeprecatedString& baseURL)
     1522{
     1523    m_baseURL = baseURL;
     1524    if (m_elemSheet)
     1525        m_elemSheet->setHref(m_baseURL);
     1526}
     1527
    15211528void Document::setCSSStyleSheet(const String &url, const String& charset, const String &sheet)
    15221529{

  • trunk/WebCore/dom/Document.h

    r19595 r19716  
    338338
    339339    DeprecatedString baseURL() const { return m_baseURL.isEmpty() ? URL() : m_baseURL; }
    340     void setBaseURL(const DeprecatedString& baseURL) { m_baseURL = baseURL; }
     340    void setBaseURL(const DeprecatedString& baseURL);
    341341
    342342    String baseTarget() const { return m_baseTarget; }
Note: See TracChangeset for help on using the changeset viewer.