Changeset 19719 in webkit

Timestamp:

Feb 19, 2007 7:01:04 PM (17 years ago)

Author:

weinig

Message:

LayoutTests:

Reviewed by Hyatt.

• repaint test for ​http://bugs.webkit.org/show_bug.cgi?id=12817 REGRESSION (r18634): Table border-collapse problems with right margin

• fast/repaint/table-outer-border-expected.checksum: Added.
• fast/repaint/table-outer-border-expected.png: Added.
• fast/repaint/table-outer-border-expected.txt: Added.
• fast/repaint/table-outer-border.html: Added.

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12817 REGRESSION (r18634): Table border-collapse problems with right margin

Test: fast/repaint/table-outer-border.html

• rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Reordered to initialize horizontal overflow after table sections have computed their outer horizontal borders.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/table-outer-border-expected.checksum (added)
• LayoutTests/fast/repaint/table-outer-border-expected.png (added)
• LayoutTests/fast/repaint/table-outer-border-expected.txt (added)
• LayoutTests/fast/repaint/table-outer-border.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderTable.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-02-19  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Hyatt.
+
+        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=12817
+          REGRESSION (r18634): Table border-collapse problems with right margin
+
+        * fast/repaint/table-outer-border-expected.checksum: Added.
+        * fast/repaint/table-outer-border-expected.png: Added.
+        * fast/repaint/table-outer-border-expected.txt: Added.
+        * fast/repaint/table-outer-border.html: Added.
+
 2007-02-19  Zalan Bujtas  <zbujtas@gmail.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-02-19  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Hyatt.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=12817
+          REGRESSION (r18634): Table border-collapse problems with right margin
+
+        Test: fast/repaint/table-outer-border.html
+
+        * rendering/RenderTable.cpp:
+        (WebCore::RenderTable::layout): Reordered to initialize horizontal overflow
+        after table sections have computed their outer horizontal borders.
+
 2007-02-19  John Sullivan  <sullivan@apple.com>
 

trunk/WebCore/rendering/RenderTable.cpp

@@ -291 +291 @@
     calcWidth();
 
-    m_overflowWidth = m_width + (collapseBorders() ? outerBorderRight() - borderRight() : 0);
-    m_overflowLeft = collapseBorders() ? borderLeft() - outerBorderLeft() : 0;
-
     // FIXME: The optimisation below doesn't work since the internal table
     // layout could have changed.  we need to add a flag to the table
@@ -318 +315 @@
         child = child->nextSibling();
     }
+
+    m_overflowWidth = m_width + (collapseBorders() ? outerBorderRight() - borderRight() : 0);
+    m_overflowLeft = collapseBorders() ? borderLeft() - outerBorderLeft() : 0;
 
     // If any table section moved vertically, we will just repaint everything from that