Changeset 197513 in webkit

Timestamp:

Mar 3, 2016 11:46:25 AM (8 years ago)

Author:

beidson@apple.com

Message:

storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html flaky on mac-wk2.
​https://bugs.webkit.org/show_bug.cgi?id=154747

Reviewed by Alex Christensen.

This callback coming out of order like this is okay, so the test should just allow it.

It makes sense that the flake is WK2-only, since WK1 has a much more well defined order
with thread-hopping versus process-hopping.

• storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
• storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt:
• storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt (modified) (1 diff)
• storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt (modified) (1 diff)
• storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-03-03  Brady Eidson  <beidson@apple.com>
+
+        storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html flaky on mac-wk2.
+        https://bugs.webkit.org/show_bug.cgi?id=154747
+
+        Reviewed by Alex Christensen.
+        
+        This callback coming out of order like this is okay, so the test should just allow it.
+
+        It makes sense that the flake is WK2-only, since WK1 has a much more well defined order 
+        with thread-hopping versus process-hopping.
+
+        * storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
+        * storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt:
+        * storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js:
+
 2016-03-03  Brady Eidson  <beidson@apple.com>
 

trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt

@@ -25 +25 @@
 sawVersionChange = true
 
-deleteBlockedCallback():
-PASS sawVersionChange is true
-sawDeleteBlocked = true
-
 openSuccess():
 PASS sawUpgradeNeeded is true

trunk/LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private-expected.txt

@@ -25 +25 @@
 sawVersionChange = true
 
-deleteBlockedCallback():
-PASS sawVersionChange is true
-sawDeleteBlocked = true
-
 openSuccess():
 PASS sawUpgradeNeeded is true

trunk/LayoutTests/storage/indexeddb/resources/delete-in-upgradeneeded-close-in-open-success.js

@@ -63 +63 @@
 function deleteBlockedCallback(evt)
 {
-    preamble(evt);
-    shouldBeTrue("sawVersionChange");
-    evalAndLog("sawDeleteBlocked = true");
+    if (!sawVersionChange)
+        debug("deleteBlockedCallback was called *before* versionChangeCallback, which is wrong");
+    eval("sawDeleteBlocked = true");
 }