Changeset 197659 in webkit

Timestamp:

Mar 6, 2016 10:41:51 PM (8 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Use half-pixel borders for data grids
​https://bugs.webkit.org/show_bug.cgi?id=154437
<rdar://problem/24736365>

Reviewed by Timothy Hatcher.

• UserInterface/Views/DataGrid.css:

(.data-grid.inline):
(.data-grid th):
(.data-grid :matches(th, td):not(:last-child)):
Half-pixel borders round to 1px on 1x (non-retina) screens since r192444.

• UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype._positionResizerElements):
Use getBoundingClientRect for better precision since it provides subpixel values.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DataGrid.css (modified) (3 diffs)
• UserInterface/Views/DataGrid.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-03-06  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Use half-pixel borders for data grids
+        https://bugs.webkit.org/show_bug.cgi?id=154437
+        <rdar://problem/24736365>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/DataGrid.css:
+        (.data-grid.inline):
+        (.data-grid th):
+        (.data-grid :matches(th, td):not(:last-child)):
+        Half-pixel borders round to 1px on 1x (non-retina) screens since r192444.
+
+        * UserInterface/Views/DataGrid.js:
+        (WebInspector.DataGrid.prototype._positionResizerElements):
+        Use getBoundingClientRect for better precision since it provides subpixel values.
+
 2016-03-05  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css

@@ -59 +59 @@
 
 .data-grid.inline {
-    border: 1px solid var(--border-color);
+    border: 0.5px solid var(--border-color);
 }
 
@@ -76 +76 @@
     background-color: white;
 
-    border-bottom: 1px solid var(--border-color);
+    border-bottom: 0.5px solid var(--border-color);
 
     font-weight: normal;
@@ -88 +88 @@
 
 .data-grid :matches(th, td):not(:last-child) {
-    border-right: 1px solid var(--border-color);
+    border-right: 0.5px solid var(--border-color);
 }
 

trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js

@@ -700 +700 @@
             // header table in order to determine the width of the column, since
             // it is not possible to query a column for its width.
-            left += this._headerTableBodyElement.rows[0].cells[i].offsetWidth;
+            left += this._headerTableBodyElement.rows[0].cells[i].getBoundingClientRect().width;
 
             if (this._isColumnVisible(this.orderedColumns[i])) {