Changeset 19784 in webkit
- Timestamp:
- Feb 21, 2007 6:58:27 PM (17 years ago)
- Location:
- trunk
- Files:
-
- 4 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r19780 r19784 1 2007-02-21 Mitz Pettel <mitz@webkit.org> 2 3 Reviewed by Hyatt. 4 5 - test for http://bugs.webkit.org/show_bug.cgi?id=12818 6 REGRESSION (r19148): shacknews.com does not render completely 7 8 * fast/dynamic/staticY-marking-parents-regression-expected.checksum: Added. 9 * fast/dynamic/staticY-marking-parents-regression-expected.png: Added. 10 * fast/dynamic/staticY-marking-parents-regression-expected.txt: Added. 11 * fast/dynamic/staticY-marking-parents-regression.html: Added. 12 1 13 2007-02-21 Justin Garcia <justin.garcia@apple.com> 2 14 -
trunk/WebCore/ChangeLog
r19783 r19784 1 2007-02-21 Mitz Pettel <mitz@webkit.org> 2 3 Reviewed by Hyatt. 4 5 - fix http://bugs.webkit.org/show_bug.cgi?id=12818 6 REGRESSION (r19148): shacknews.com does not render completely 7 8 Test: fast/dynamic/staticY-marking-parents-regression.html 9 10 Changed calls to setChildNeedsLayout(true) during layout to 11 setChildNeedsLayout(true, false). Prior to r19148, the default behavior 12 of marking containers did not matter because the caller was the container 13 and was already marked, but r19148 added marking of the parent of 14 objects with static Y, which can be different from the caller and not 15 necessarily marked already. 16 17 * rendering/RenderBlock.cpp: 18 (WebCore::RenderBlock::collapseMargins): 19 (WebCore::RenderBlock::clearFloatsIfNeeded): 20 (WebCore::RenderBlock::layoutBlockChildren): 21 * rendering/RenderBox.cpp: 22 (WebCore::RenderBox::setStaticY): 23 * rendering/RenderFlexibleBox.cpp: 24 (WebCore::RenderFlexibleBox::layoutVerticalBox): 25 1 26 2007-02-21 Brady Eidson <beidson@apple.com> 2 27 -
trunk/WebCore/rendering/RenderBlock.cpp
r19717 r19784 889 889 // change (because it has more available line width). 890 890 // So go ahead and mark the item as dirty. 891 child->setChildNeedsLayout(true );891 child->setChildNeedsLayout(true, false); 892 892 893 893 if (!child->avoidsFloats() && child->containsFloats()) … … 944 944 // change (because it has more available line width). 945 945 // So go ahead and mark the item as dirty. 946 child->setChildNeedsLayout(true );946 child->setChildNeedsLayout(true, false); 947 947 if (!child->avoidsFloats() && child->containsFloats()) 948 948 child->markAllDescendantsWithFloatsForLayout(); … … 1097 1097 // an auto value. Add a method to determine this, so that we can avoid the relayout. 1098 1098 if (relayoutChildren || (child->style()->height().isPercent() || child->style()->minHeight().isPercent() || child->style()->maxHeight().isPercent())) 1099 child->setChildNeedsLayout(true );1099 child->setChildNeedsLayout(true, false); 1100 1100 1101 1101 // Handle the four types of special elements first. These include positioned content, floating content, compacts and … … 1124 1124 int fb = floatBottom(); 1125 1125 if (fb > m_height || fb > yPosEstimate) 1126 child->setChildNeedsLayout(true );1126 child->setChildNeedsLayout(true, false); 1127 1127 } 1128 1128 -
trunk/WebCore/rendering/RenderBox.cpp
r19717 r19784 1457 1457 1458 1458 m_staticY = staticY; 1459 setChildNeedsLayout(true );1459 setChildNeedsLayout(true, false); 1460 1460 } 1461 1461 -
trunk/WebCore/rendering/RenderFlexibleBox.cpp
r19696 r19784 687 687 child->setOverrideSize(-1); 688 688 if (!relayoutChildren) 689 child->setChildNeedsLayout(true );689 child->setChildNeedsLayout(true, false); 690 690 haveFlex = true; 691 691 unsigned int flexGroup = child->style()->boxFlexGroup(); … … 710 710 if (relayoutChildren || (child->isReplaced() && (child->style()->width().isPercent() || child->style()->height().isPercent())) || 711 711 (child->style()->height().isAuto() && child->isBlockFlow() && !child->needsLayout())) { 712 child->setChildNeedsLayout(true );712 child->setChildNeedsLayout(true, false); 713 713 714 714 // Dirty all the positioned objects. … … 740 740 continue; 741 741 742 child->setChildNeedsLayout(true );742 child->setChildNeedsLayout(true, false); 743 743 child->setOverrideSize(newHeight); 744 744 m_flexingChildren = true; … … 820 820 // make sure we relayout children if we need it. 821 821 if (!haveLineClamp && (relayoutChildren || (child->isReplaced() && (child->style()->width().isPercent() || child->style()->height().isPercent())))) 822 child->setChildNeedsLayout(true );822 child->setChildNeedsLayout(true, false); 823 823 824 824 if (child->isPositioned())
Note: See TracChangeset
for help on using the changeset viewer.