Changeset 19822 in webkit


Ignore:
Timestamp:
Feb 22, 2007 10:48:54 PM (17 years ago)
Author:
kjk
Message:

Reviewed by Adam Roben, who never sleeps.

To avoid code duplication, move notImplementedGdk() macro to a separate
header file. Remove existing notImplementedGdk() macros and replace
remaining notImplemented() to notImplementedGdk() in gdk code.

  • loader/gdk/DocumentLoaderGdk.cpp: (WebCore::DocumentLoader::getResponseModifiedHeader):
  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView):
  • page/gdk/ContextMenuClientGdk.cpp: (WebCore::ContextMenuClientGdk::contextMenuDestroyed): (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientGdk::contextMenuItemSelected): (WebCore::ContextMenuClientGdk::downloadURL): (WebCore::ContextMenuClientGdk::copyImageToClipboard): (WebCore::ContextMenuClientGdk::searchWithGoogle): (WebCore::ContextMenuClientGdk::lookUpInDictionary): (WebCore::ContextMenuClientGdk::speak): (WebCore::ContextMenuClientGdk::stopSpeaking):
  • page/gdk/EventHandlerGdk.cpp:
  • platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor):
  • platform/gdk/EditorClientGdk.cpp:
  • platform/gdk/NotImplementedGdk.h: Added.
  • platform/gdk/PopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement):
  • platform/gdk/RenderThemeGdk.cpp:
  • platform/gdk/ScreenGdk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::drawPattern):
  • platform/network/gdk/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST):
Location:
trunk/WebCore
Files:
1 added
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r19820 r19822  
     12007-02-22  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
     2
     3        Reviewed by Adam Roben, who never sleeps.
     4
     5        To avoid code duplication, move notImplementedGdk() macro to a separate
     6        header file. Remove existing notImplementedGdk() macros and replace
     7        remaining notImplemented() to notImplementedGdk() in gdk code.
     8
     9        * loader/gdk/DocumentLoaderGdk.cpp:
     10        (WebCore::DocumentLoader::getResponseModifiedHeader):
     11        * loader/gdk/FrameLoaderClientGdk.cpp:
     12        (WebCore::FrameLoaderClientGdk::hasWebView):
     13        (WebCore::FrameLoaderClientGdk::hasFrameView):
     14        * page/gdk/ContextMenuClientGdk.cpp:
     15        (WebCore::ContextMenuClientGdk::contextMenuDestroyed):
     16        (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems):
     17        (WebCore::ContextMenuClientGdk::contextMenuItemSelected):
     18        (WebCore::ContextMenuClientGdk::downloadURL):
     19        (WebCore::ContextMenuClientGdk::copyImageToClipboard):
     20        (WebCore::ContextMenuClientGdk::searchWithGoogle):
     21        (WebCore::ContextMenuClientGdk::lookUpInDictionary):
     22        (WebCore::ContextMenuClientGdk::speak):
     23        (WebCore::ContextMenuClientGdk::stopSpeaking):
     24        * page/gdk/EventHandlerGdk.cpp:
     25        * platform/gdk/CursorGdk.cpp:
     26        (WebCore::Cursor::Cursor):
     27        * platform/gdk/EditorClientGdk.cpp:
     28        * platform/gdk/NotImplementedGdk.h: Added.
     29        * platform/gdk/PopupMenuGdk.cpp:
     30        (WebCore::PopupMenu::PopupMenu):
     31        (WebCore::PopupMenu::~PopupMenu):
     32        (WebCore::PopupMenu::show):
     33        (WebCore::PopupMenu::hide):
     34        (WebCore::PopupMenu::updateFromElement):
     35        * platform/gdk/RenderThemeGdk.cpp:
     36        * platform/gdk/ScreenGdk.cpp:
     37        (WebCore::screenDepth):
     38        (WebCore::screenDepthPerComponent):
     39        (WebCore::screenIsMonochrome):
     40        (WebCore::screenRect):
     41        (WebCore::screenAvailableRect):
     42        * platform/gdk/TemporaryLinkStubs.cpp:
     43        * platform/graphics/gdk/ImageGdk.cpp:
     44        (WebCore::Image::drawPattern):
     45        * platform/network/gdk/ResourceHandleCurl.cpp:
     46        (WebCore::ResourceHandle::setDefersLoading):
     47        * platform/network/gdk/ResourceHandleManager.cpp:
     48        (WebCore::ResourceHandleManager::setupPUT):
     49        (WebCore::ResourceHandleManager::setupPOST):
     50
    1512007-02-22  Ian Eng  <ian.eng.webkit@gmail.com>
    252

  • trunk/WebCore/loader/gdk/DocumentLoaderGdk.cpp

    r19475 r19822  
    3131
    3232#include "KURL.h"
     33#include "NotImplementedGdk.h"
    3334#include <stdio.h>
    34 
    35 #define notImplemented() do { fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", __PRETTY_FUNCTION__, __FILE__, __LINE__); } while(0)
    36 
     35 
    3736namespace WebCore {
    3837
    3938bool DocumentLoader::getResponseModifiedHeader(String& modified) const
    4039{
    41     notImplemented();
     40    notImplementedGdk();
    4241    return false;
    4342}

  • trunk/WebCore/loader/gdk/FrameLoaderClientGdk.cpp

    r19788 r19822  
    3434#include "FrameGdk.h"
    3535#include "FrameLoader.h"
     36#include "NotImplementedGdk.h"
    3637#include "PlatformString.h"
    3738#include "ResourceRequest.h"
    3839#include <stdio.h>
    3940
    40 #define notImplementedGdk() do { \
    41     static int count; \
    42     if (!count && !getenv("DISABLE_NI_WARNING")) \
    43         fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", WTF_PRETTY_FUNCTION, __FILE__, __LINE__); \
    44     ++count; \
    45  } while(0)
    46 
    47 namespace WebCore
    48 {
     41namespace WebCore {
    4942
    5043FrameLoaderClientGdk::FrameLoaderClientGdk()
    … …  
    213206bool FrameLoaderClientGdk::hasWebView() const
    214207{
    215     //notImplementedGdk();
     208    notImplementedGdk();
    216209    return true;
    217210}
    … …  
    219212bool FrameLoaderClientGdk::hasFrameView() const
    220213{
    221     //notImplementedGdk();
     214    notImplementedGdk();
    222215    return true;
    223216}

  • trunk/WebCore/page/gdk/ContextMenuClientGdk.cpp

    r19647 r19822  
    2929#include "HitTestResult.h"
    3030#include "KURL.h"
     31#include "NotImplementedGdk.h"
    3132
    3233#include <stdio.h>
    33 
    34 #define notImplemented() do { fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", __PRETTY_FUNCTION__, __FILE__, __LINE__); } while(0)
    3534
    3635namespace WebCore {
    … …  
    3837void ContextMenuClientGdk::contextMenuDestroyed()
    3938{
    40     notImplemented();
     39    notImplementedGdk();
    4140}
    4241
    4342PlatformMenuDescription ContextMenuClientGdk::getCustomMenuFromDefaultItems(ContextMenu*)
    4443{
    45     notImplemented();
     44    notImplementedGdk();
    4645    return PlatformMenuDescription();
    4746}
    … …  
    4948void ContextMenuClientGdk::contextMenuItemSelected(ContextMenuItem*, const ContextMenu*)
    5049{
    51     notImplemented();
     50    notImplementedGdk();
    5251}
    5352
    5453void ContextMenuClientGdk::downloadURL(const KURL& url)
    5554{
    56     notImplemented();
     55    notImplementedGdk();
    5756}
    5857
    5958void ContextMenuClientGdk::copyImageToClipboard(const HitTestResult&)
    6059{
    61     notImplemented();
     60    notImplementedGdk();
    6261}
    6362
    6463void ContextMenuClientGdk::searchWithGoogle(const Frame*)
    6564{
    66     notImplemented();
     65    notImplementedGdk();
    6766}
    6867
    6968void ContextMenuClientGdk::lookUpInDictionary(Frame*)
    7069{
    71     notImplemented();
     70    notImplementedGdk();
    7271}
    7372
    7473void ContextMenuClientGdk::speak(const String&)
    7574{
    76     notImplemented();
     75    notImplementedGdk();
    7776}
    7877
    7978void ContextMenuClientGdk::stopSpeaking()
    8079{
    81     notImplemented();
     80    notImplementedGdk();
    8281}
    8382

  • trunk/WebCore/page/gdk/EventHandlerGdk.cpp

    r19788 r19822  
    3434#include "KeyboardEvent.h"
    3535#include "MouseEventWithHitTestResults.h"
     36#include "NotImplementedGdk.h"
    3637#include "Page.h"
    3738#include "PlatformScrollBar.h"
    … …  
    4243
    4344using namespace EventNames;
    44 
    45 #define notImplementedGdk() do { \
    46     static int count; \
    47     if (!count && !getenv("DISABLE_NI_WARNING")) \
    48         fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", WTF_PRETTY_FUNCTION, __FILE__, __LINE__); \
    49     ++count; \
    50  } while(0)
    5145
    5246static bool isKeyboardOptionTab(KeyboardEvent* event)

  • trunk/WebCore/platform/gdk/CursorGdk.cpp

    r19741 r19822  
    3030
    3131#include "DeprecatedString.h"
     32#include "NotImplementedGdk.h"
     33#include <wtf/Assertions.h>
     34
    3235#include <gdk/gdk.h>
    3336#include <stdio.h>
    34 #include <stdlib.h>
    35 #include <wtf/Assertions.h>
    36 
    37 #define notImplemented() do { fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", __PRETTY_FUNCTION__, __FILE__, __LINE__); } while(0)
    38 
     37 
    3938namespace WebCore {
    4039
    … …  
    4847Cursor::Cursor(Image*, const IntPoint&)
    4948{
    50     notImplemented();
     49    notImplementedGdk();
    5150}
    5251

  • trunk/WebCore/platform/gdk/EditorClientGdk.cpp

    r19788 r19822  
    3939#include "Page.h"
    4040#include "PlatformKeyboardEvent.h"
     41#include "NotImplementedGdk.h"
    4142
    4243#include <stdio.h>
    43 
    44 #define notImplementedGdk() do { \
    45     static int count; \
    46     if (!count && !getenv("DISABLE_NI_WARNING")) \
    47         fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", WTF_PRETTY_FUNCTION, __FILE__, __LINE__); \
    48     ++count; \
    49  } while(0)
    5044
    5145namespace WebCore {

  • trunk/WebCore/platform/gdk/PopupMenuGdk.cpp

    r19495 r19822  
    2525#include "PopupMenu.h"
    2626
     27#include "NotImplementedGdk.h"
     28
    2729#include <stdio.h>
    28 
    29 #define notImplemented() do { fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", __PRETTY_FUNCTION__, __FILE__, __LINE__); } while(0)
    30 
     30 
    3131namespace WebCore {
    3232
    3333PopupMenu::PopupMenu(PopupMenuClient* menuList)
    3434{
    35     notImplemented();
     35    notImplementedGdk();
    3636}
    3737
    3838PopupMenu::~PopupMenu()
    3939{
    40     notImplemented();
     40    notImplementedGdk();
    4141}
    4242
    4343void PopupMenu::show(const IntRect&, FrameView*, int)
    4444{
    45     notImplemented();
     45    notImplementedGdk();
    4646}
    4747
    4848void PopupMenu::hide()
    4949{
    50     notImplemented();
     50    notImplementedGdk();
    5151}
    5252
    5353void PopupMenu::updateFromElement()
    5454{
    55     notImplemented();
     55    notImplementedGdk();
    5656}
    5757

  • trunk/WebCore/platform/gdk/RenderThemeGdk.cpp

    r19788 r19822  
    2727
    2828#include "GraphicsContext.h"
     29#include "NotImplementedGdk.h"
    2930#include "RenderObject.h"
    30 
    31 #define notImplementedGdk() do { \
    32     static int count; \
    33     if (!count && !getenv("DISABLE_NI_WARNING")) \
    34         fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", WTF_PRETTY_FUNCTION, __FILE__, __LINE__); \
    35     ++count; \
    36  } while(0)
    3731
    3832#define THEME_COLOR 204

  • trunk/WebCore/platform/gdk/ScreenGdk.cpp

    r19511 r19822  
    2929#include "Screen.h"
    3030
     31#include "NotImplementedGdk.h"
     32#include <wtf/Assertions.h>
    3133#include <stdio.h>
    32 
    33 #define notImplemented() do { fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", __PRETTY_FUNCTION__, __FILE__, __LINE__); } while(0)
    3434
    3535namespace WebCore {
    … …  
    3737int screenDepth(Widget*)
    3838{
    39     notImplemented();
     39    notImplementedGdk();
    4040    return 32;
    4141}
    … …  
    4343int screenDepthPerComponent(Widget*)
    4444{
    45     notImplemented();
     45    notImplementedGdk();
    4646    return 8;
    4747}
    … …  
    4949bool screenIsMonochrome(Widget*)
    5050{
    51     notImplemented();
     51    notImplementedGdk();
    5252    return false;
    5353}
    … …  
    5555FloatRect screenRect(Widget*)
    5656{
    57     notImplemented();
     57    notImplementedGdk();
    5858    return FloatRect();
    5959}
    … …  
    6161FloatRect screenAvailableRect(Widget*)
    6262{
    63     notImplemented();
     63    notImplementedGdk();
    6464    return FloatRect();
    6565}

  • trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

    r19788 r19822  
    6161#include "MainResourceLoader.h"
    6262#include "Node.h"
     63#include "NotImplementedGdk.h"
    6364#include "PageCache.h"
    6465#include "Pasteboard.h"
    … …  
    7879
    7980using namespace WebCore;
    80 
    81 #define notImplementedGdk() do { \
    82     static int count; \
    83     if (!count && !getenv("DISABLE_NI_WARNING")) \
    84         fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", WTF_PRETTY_FUNCTION, __FILE__, __LINE__); \
    85     ++count; \
    86  } while(0)
    8781
    8882namespace WebCore {

  • trunk/WebCore/platform/graphics/gdk/ImageGdk.cpp

    r19481 r19822  
    2828
    2929#include "BitmapImage.h"
     30#include "NotImplementedGdk.h"
    3031#include <cairo.h>
    31 
    32 #define notImplemented() do { fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", __PRETTY_FUNCTION__, __FILE__, __LINE__); } while(0)
    33 
     32 
    3433// This function loads resources from WebKit
    3534Vector<char> loadResourceIntoArray(const char*);
    … …  
    5655                        const FloatPoint& phase, CompositeOperator op, const FloatRect& destRect)
    5756{
    58     notImplemented();
     57    notImplementedGdk();
    5958}
    6059}

  • trunk/WebCore/platform/network/gdk/ResourceHandleCurl.cpp

    r19677 r19822  
    3030
    3131#include "DocLoader.h"
     32#include "NotImplementedGdk.h"
    3233#include "ResourceHandleInternal.h"
    3334#include "ResourceHandleManager.h"
    34 
    35 #define notImplemented() do { fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", __PRETTY_FUNCTION__, __FILE__, __LINE__); } while(0)
    3635
    3736namespace WebCore {
    … …  
    7675{
    7776    d->m_defersLoading = defers;
    78     notImplemented();
     77    notImplementedGdk();
    7978}
    8079

  • trunk/WebCore/platform/network/gdk/ResourceHandleManager.cpp

    r19677 r19822  
    3030
    3131#include "CString.h"
     32#include "NotImplementedGdk.h"
    3233#include "ResourceHandle.h"
    3334#include "ResourceHandleInternal.h"
    34 
    35 #include <stdio.h>
    36 
    37 #define notImplemented() do { fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n", __PRETTY_FUNCTION__, __FILE__, __LINE__); } while(0)
    3835
    3936namespace WebCore {
    … …  
    171168void ResourceHandleManager::setupPUT(ResourceHandle*)
    172169{
    173     notImplemented();
     170    notImplementedGdk();
    174171}
    175172
    176173void ResourceHandleManager::setupPOST(ResourceHandle*)
    177174{
    178     notImplemented();
     175    notImplementedGdk();
    179176}
    180177
Note: See TracChangeset for help on using the changeset viewer.