Changeset 198269 in webkit

Timestamp:

Mar 16, 2016 2:36:29 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r195661): [GTK] very slow scrolling
​https://bugs.webkit.org/show_bug.cgi?id=155334

Reviewed by Sergio Villar Senin.

Fix smooth scrolling behaviour change after r195661.

• platform/ScrollAnimationSmooth.cpp:

(WebCore::getAnimationParametersForGranularity): Fix a typo,
animationTime for pixel granularity should be 11 * tickTime.
(WebCore::ScrollAnimationSmooth::animateScroll): Previous code
reset all the data except the visibleLenght, so keep it in the
PerAxisData after the reset.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ScrollAnimationSmooth.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-03-16  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r195661): [GTK] very slow scrolling
+        https://bugs.webkit.org/show_bug.cgi?id=155334
+
+        Reviewed by Sergio Villar Senin.
+
+        Fix smooth scrolling behaviour change after r195661.
+
+        * platform/ScrollAnimationSmooth.cpp:
+        (WebCore::getAnimationParametersForGranularity): Fix a typo,
+        animationTime for pixel granularity should be 11 * tickTime.
+        (WebCore::ScrollAnimationSmooth::animateScroll): Previous code
+        reset all the data except the visibleLenght, so keep it in the
+        PerAxisData after the reset.
+
 2016-03-16  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/platform/ScrollAnimationSmooth.cpp

@@ -258 +258 @@
         break;
     case ScrollByPixel:
-        animationTime = 1 * tickTime;
+        animationTime = 11 * tickTime;
         repeatMinimumSustainTime = 2 * tickTime;
         attackTime = 3 * tickTime;
@@ -381 +381 @@
     if (deltaTime > data.animationTime) {
         double desiredPosition = data.desiredPosition;
+        int visibleLength = data.visibleLength;
         data = PerAxisData();
         data.currentPosition = desiredPosition;
+        data.visibleLength = visibleLength;
         return false;
     }