Changeset 198511 in webkit

Timestamp:

Mar 21, 2016 5:51:43 PM (8 years ago)

Author:

Matt Baker

Message:

Web Inspector: New icon for Heap Allocations timeline
​https://bugs.webkit.org/show_bug.cgi?id=155731
<rdar://problem/25275494>

Reviewed by Joseph Pecoraro and Timothy Hatcher.

• UserInterface/Images/HeapAllocationsInstrument.svg: Added.

New artwork from Jon Davis.

• UserInterface/Views/TimelineIcons.css:

(.heap-allocations-icon .icon):
(body:not(.mac-platform, .windows-platform) .memory-icon .icon):
(body:not(.mac-platform, .windows-platform) .heap-allocations-icon .icon):
New icon styles/fallbacks for GTK.

• UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.iconClassNameForTimeline):
Add new icon class to UI helper method.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Images/HeapAllocationsInstrument.svg (added)
• UserInterface/Views/TimelineIcons.css (modified) (2 diffs)
• UserInterface/Views/TimelineTabContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-03-21  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: New icon for Heap Allocations timeline
+        https://bugs.webkit.org/show_bug.cgi?id=155731
+        <rdar://problem/25275494>
+
+        Reviewed by Joseph Pecoraro and Timothy Hatcher.
+
+        * UserInterface/Images/HeapAllocationsInstrument.svg: Added.
+        New artwork from Jon Davis.
+
+        * UserInterface/Views/TimelineIcons.css:
+        (.heap-allocations-icon .icon):
+        (body:not(.mac-platform, .windows-platform) .memory-icon .icon):
+        (body:not(.mac-platform, .windows-platform) .heap-allocations-icon .icon):
+        New icon styles/fallbacks for GTK.
+
+        * UserInterface/Views/TimelineTabContentView.js:
+        (WebInspector.TimelineTabContentView.iconClassNameForTimeline):
+        Add new icon class to UI helper method.
+
 2016-03-20  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css

@@ -36 +36 @@
 }
 
+.heap-allocations-icon .icon {
+    content: url(../Images/HeapAllocationsInstrument.svg);
+}
+
 .layout-icon .icon {
     content: url(../Images/LayoutInstrument.svg);
@@ -71 +75 @@
 body:not(.mac-platform, .windows-platform) .rendering-frame-icon .icon {
     content: -webkit-image-set(url(../Images/Frames.png) 1x, url(../Images/Frames@2x.png) 2x);
+}
+
+body:not(.mac-platform, .windows-platform) .memory-icon .icon {
+    content: -webkit-image-set(url(../Images/ScriptLarge.png) 1x, url(../Images/ScriptLarge@2x.png) 2x);
+}
+
+body:not(.mac-platform, .windows-platform) .heap-allocations-icon .icon {
+    content: -webkit-image-set(url(../Images/ScriptLarge.png) 1x, url(../Images/ScriptLarge@2x.png) 2x);
 }
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js

@@ -138 +138 @@
             return "memory-icon";
         case WebInspector.TimelineRecord.Type.HeapAllocations:
-            // FIXME: HeapAllocation Timeline needs a new icon.
-            return "memory-icon";
+            return "heap-allocations-icon";
         case WebInspector.TimelineRecord.Type.Script:
             return "script-icon";