Changeset 19875 in webkit

Timestamp:

Feb 26, 2007 9:13:49 PM (17 years ago)

Author:

bdash

Message:

2007-02-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Antti Koivisto.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12899 Ordered lists not updating dynamically with new styles <rdar://problem/4889356>

Test: fast/lists/list-style-type-dynamic-change.html

• rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::setStyle): Made changing the marker type trigger updating of the marker.

2007-02-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Antti Koivisto.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=12899 Ordered lists not updating dynamically with new styles

• fast/lists/list-style-type-dynamic-change-expected.checksum: Added.
• fast/lists/list-style-type-dynamic-change-expected.png: Added.
• fast/lists/list-style-type-dynamic-change-expected.txt: Added.
• fast/lists/list-style-type-dynamic-change.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/lists/list-style-type-dynamic-change-expected.checksum (added)
• LayoutTests/fast/lists/list-style-type-dynamic-change-expected.png (added)
• LayoutTests/fast/lists/list-style-type-dynamic-change-expected.txt (added)
• LayoutTests/fast/lists/list-style-type-dynamic-change.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderListMarker.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-02-26  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Antti Koivisto.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=12899
+          Ordered lists not updating dynamically with new styles
+
+        * fast/lists/list-style-type-dynamic-change-expected.checksum: Added.
+        * fast/lists/list-style-type-dynamic-change-expected.png: Added.
+        * fast/lists/list-style-type-dynamic-change-expected.txt: Added.
+        * fast/lists/list-style-type-dynamic-change.html: Added.
+
 2007-02-26  Adele Peterson  <adele@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-02-26  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Antti Koivisto.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=12899
+          Ordered lists not updating dynamically with new styles
+
+        Test: fast/lists/list-style-type-dynamic-change.html
+
+        * rendering/RenderListMarker.cpp:
+        (WebCore::RenderListMarker::setStyle): Made changing the marker type trigger
+        updating of the marker.
+
 2007-02-26  Adele Peterson  <adele@apple.com>
 

trunk/WebCore/rendering/RenderListMarker.cpp

@@ -483 +483 @@
 void RenderListMarker::setStyle(RenderStyle* s)
 {
-    if (s && style() && s->listStylePosition() != style()->listStylePosition())
+    if (s && style() && (s->listStylePosition() != style()->listStylePosition() || s->listStyleType() != style()->listStyleType()))
         setNeedsLayoutAndMinMaxRecalc();