Changeset 198917 in webkit


Ignore:
Timestamp:
Mar 31, 2016 2:12:55 PM (8 years ago)
Author:
Chris Dumez
Message:

REGRESSION (r191180): Safari does not send Referer Header to iframe src in certain situations
https://bugs.webkit.org/show_bug.cgi?id=155754
<rdar://problem/25296445>

Unreviewed, roll out r191180 as it breaks sites and needs to be reworked.

Source/WebCore:

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::tagIdFor): Deleted.
(WebCore::TokenPreloadScanner::initiatorFor): Deleted.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): Deleted.
(WebCore::TokenPreloadScanner::StartTagScanner::resourceType): Deleted.

  • html/parser/HTMLPreloadScanner.h:

LayoutTests:

  • fast/preloader/frame-src-expected.txt: Removed.
  • fast/preloader/frame-src.html: Removed.
  • fast/preloader/resources/testFrame.html: Removed.
  • http/tests/loading/preload-no-store-frame-src-expected: Removed.
  • http/tests/loading/preload-no-store-frame-src.html: Removed.
Location:
trunk
Files:
5 deleted
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r198912 r198917  
     12016-03-31  Chris Dumez  <cdumez@apple.com>
     2
     3        REGRESSION (r191180): Safari does not send Referer Header to iframe src in certain situations
     4        https://bugs.webkit.org/show_bug.cgi?id=155754
     5        <rdar://problem/25296445>
     6
     7        Unreviewed, roll out r191180 as it breaks sites and needs to be reworked.
     8
     9        * fast/preloader/frame-src-expected.txt: Removed.
     10        * fast/preloader/frame-src.html: Removed.
     11        * fast/preloader/resources/testFrame.html: Removed.
     12        * http/tests/loading/preload-no-store-frame-src-expected: Removed.
     13        * http/tests/loading/preload-no-store-frame-src.html: Removed.
     14
    1152016-03-31  Eric Carlson  <eric.carlson@apple.com>
    216
  • trunk/Source/WebCore/ChangeLog

    r198911 r198917  
     12016-03-31  Chris Dumez  <cdumez@apple.com>
     2
     3        REGRESSION (r191180): Safari does not send Referer Header to iframe src in certain situations
     4        https://bugs.webkit.org/show_bug.cgi?id=155754
     5        <rdar://problem/25296445>
     6
     7        Unreviewed, roll out r191180 as it breaks sites and needs to be reworked.
     8
     9        * html/parser/HTMLPreloadScanner.cpp:
     10        (WebCore::TokenPreloadScanner::tagIdFor): Deleted.
     11        (WebCore::TokenPreloadScanner::initiatorFor): Deleted.
     12        (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): Deleted.
     13        (WebCore::TokenPreloadScanner::StartTagScanner::resourceType): Deleted.
     14        * html/parser/HTMLPreloadScanner.h:
     15
    1162016-03-31  Jiewen Tan  <jiewen_tan@apple.com>
    217
  • trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp

    r195452 r198917  
    4747{
    4848    AtomicString tagName(data);
    49     if (tagName == iframeTag)
    50         return TagId::Iframe;
    5149    if (tagName == imgTag)
    5250        return TagId::Img;
     
    7573{
    7674    switch (tagId) {
    77     case TagId::Iframe:
    78         return "iframe";
    7975    case TagId::Source:
    8076    case TagId::Img:
     
    177173
    178174        switch (m_tagId) {
    179         case TagId::Iframe:
    180             if (match(attributeName, srcAttr))
    181                 setUrlToLoad(attributeValue);
    182             break;
    183175        case TagId::Img:
    184176            if (inPicture && alreadyMatchedSource)
     
    273265    {
    274266        switch (m_tagId) {
    275         case TagId::Iframe:
    276             return CachedResource::MainResource;
    277267        case TagId::Script:
    278268            return CachedResource::Script;
  • trunk/Source/WebCore/html/parser/HTMLPreloadScanner.h

    r194865 r198917  
    4848    enum class TagId {
    4949        // These tags are scanned by the StartTagScanner.
    50         Iframe,
    5150        Img,
    5251        Input,
Note: See TracChangeset for help on using the changeset viewer.