Changeset 19897 in webkit

Timestamp:

Feb 27, 2007 3:13:26 PM (17 years ago)

Author:

antti

Message:

LayoutTests:

Reviewed by Hyatt.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=12918 REGRESSION: Google Finance dropdown Flickers <rdar://4988039>

• fast/events/mouseout-dead-node-expected.checksum: Added.
• fast/events/mouseout-dead-node-expected.png: Added.
• fast/events/mouseout-dead-node-expected.txt: Added.
• fast/events/mouseout-dead-node.html: Added.

WebCore:

Reviewed by Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12918 REGRESSION: Google Finance dropdown Flickers <rdar://4988039>

If a node dies while mouse is over it, it is still supposed to receive
mouseout event (wasn't case in Tiger webkit). However this event should
not propagate to any other nodes. This patch matches Firefox behavior in
this respect.

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/mouseout-dead-node-expected.checksum (added)
• LayoutTests/fast/events/mouseout-dead-node-expected.png (added)
• LayoutTests/fast/events/mouseout-dead-node-expected.txt (added)
• LayoutTests/fast/events/mouseout-dead-node.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/EventTargetNode.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-02-27  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Hyatt.
+        
+        - test for http://bugs.webkit.org/show_bug.cgi?id=12918
+        REGRESSION: Google Finance dropdown Flickers
+        <rdar://4988039>
+
+        * fast/events/mouseout-dead-node-expected.checksum: Added.
+        * fast/events/mouseout-dead-node-expected.png: Added.
+        * fast/events/mouseout-dead-node-expected.txt: Added.
+        * fast/events/mouseout-dead-node.html: Added.
+
 2007-02-27  Geoffrey Garen  <ggaren@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-02-27  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Hyatt.
+        
+        - fix http://bugs.webkit.org/show_bug.cgi?id=12918
+        REGRESSION: Google Finance dropdown Flickers
+        <rdar://4988039>
+        
+        If a node dies while mouse is over it, it is still supposed to receive
+        mouseout event (wasn't case in Tiger webkit). However this event should 
+        not propagate to any other nodes. This patch matches Firefox behavior in
+        this respect.
+
+        * dom/EventTargetNode.cpp:
+        (WebCore::EventTargetNode::dispatchGenericEvent):
+
 2007-02-27  Geoffrey Garen  <ggaren@apple.com>
 

trunk/WebCore/dom/EventTargetNode.cpp

@@ -178 +178 @@
     // work out what nodes to send event to
     DeprecatedPtrList<Node> nodeChain;
-    Node *n;
-
-    for (n = this; n; n = n->eventParentNode()) {
-        n->ref();
-        nodeChain.prepend(n);
+    
+    if (inDocument()) {
+        for (Node* n = this; n; n = n->eventParentNode()) {
+            n->ref();
+            nodeChain.prepend(n);
+        } 
+    } else {
+        // if node is not in the document just send event to itself 
+        ref();
+        nodeChain.prepend(this);
     }