Changeset 199110 in webkit
- Timestamp:
- Apr 6, 2016 12:13:50 PM (8 years ago)
- Location:
- trunk
- Files:
-
- 11 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r199106 r199110 1 2016-04-06 Joanmarie Diggs <jdiggs@igalia.com> 2 3 REGRESSION(r195463): [GTK] accessibility/roles-computedRoleString.html and accessibility/roles-exposed.html failing 4 https://bugs.webkit.org/show_bug.cgi?id=153696 5 6 Reviewed by Chris Fleizach. 7 8 Now that RenderInline style format groups are exposed as InlineRole, there is 9 no longer a corresponding computed role for ins, samp, and var elements. Updated 10 the roles-computedRoleString.html test and expectations accordingly. Also added 11 the now-correct results for Gtk for both of the previously-failing tests. 12 13 * accessibility/roles-computedRoleString-expected.txt: Updated. 14 * accessibility/roles-computedRoleString.html: Updated. 15 * platform/gtk/TestExpectations: Unskip the two tests which are now passing. 16 * platform/gtk/accessibility/roles-computedRoleString-expected.txt: Updated. 17 * platform/gtk/accessibility/roles-exposed-expected.txt: Updated. 18 1 19 2016-04-06 Keith Miller <keith_miller@apple.com> 2 20 -
trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt
r195463 r199110 43 43 PASS: input[type='url'] -> . 44 44 PASS: input[type='week'] -> . 45 PASS: ins -> group.45 PASS: ins -> . 46 46 PASS: math -> math. 47 47 PASS: meter -> progressbar. … … 52 52 PASS: pre -> group. 53 53 PASS: progress -> progressbar. 54 PASS: samp -> group.54 PASS: samp -> . 55 55 PASS: section -> region. 56 56 PASS: select:not([multiple]) -> . … … 77 77 PASS: ul -> list. 78 78 PASS: li -> listitem. 79 PASS: var -> group.79 PASS: var -> . 80 80 PASS: div[role="command"] -> . 81 81 PASS: div[role="composite"] -> . -
trunk/LayoutTests/accessibility/roles-computedRoleString.html
r195463 r199110 53 53 <input type="url" value="X" data-role="" class="ex" data-note="[type='url']"> 54 54 <input type="week" value="X" data-role="" class="ex" data-note="[type='week']"> 55 <ins data-role=" group" class="ex">X</ins>55 <ins data-role="" class="ex">X</ins> 56 56 <mark data-role="" class="ex">X</mark> 57 57 <math data-role="math" class="ex">X</math> … … 75 75 <!-- skipped <ruby/rp/rt> --> 76 76 <s data-role="" class="ex">X</s> 77 <samp data-role=" group" class="ex">X</samp>77 <samp data-role="" class="ex">X</samp> 78 78 <!-- skipped <script> --> 79 79 <section data-role="region" class="ex">X</section> … … 141 141 <li data-role="listitem" class="ex">X</li> 142 142 </ul> 143 <var data-role=" group" class="ex">X</var>143 <var data-role="" class="ex">X</var> 144 144 <wbr data-role="" class="ex">X</wbr> 145 145 -
trunk/LayoutTests/platform/gtk/TestExpectations
r198993 r199110 2663 2663 webkit.org/b/153602 tables/mozilla_expected_failures/bugs/bug89315.html [ Failure ] 2664 2664 2665 webkit.org/b/153696 accessibility/roles-computedRoleString.html [ Failure ]2666 webkit.org/b/153696 accessibility/roles-exposed.html [ Failure ]2667 2668 2665 webkit.org/b/153697 http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase.html [ Failure ] 2669 2666 webkit.org/b/153697 http/tests/security/contentSecurityPolicy/object-src-applet-archive.html [ Failure ] -
trunk/LayoutTests/platform/gtk/accessibility/roles-computedRoleString-expected.txt
r193746 r199110 43 43 PASS: input[type='url'] -> . 44 44 PASS: input[type='week'] -> . 45 PASS: ins -> . 45 46 PASS: math -> math. 46 47 PASS: meter -> progressbar. … … 49 50 PASS: li -> listitem. 50 51 PASS: p -> . 51 PASS: pre -> .52 PASS: pre -> group. 52 53 PASS: progress -> progressbar. 54 PASS: samp -> . 53 55 PASS: section -> region. 54 56 PASS: select:not([multiple]) -> . … … 78 80 PASS: ul -> list. 79 81 PASS: li -> listitem. 82 PASS: var -> . 80 83 PASS: div[role="command"] -> . 81 84 PASS: div[role="composite"] -> . -
trunk/LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt
r189467 r199110 45 45 46 46 cite 47 AXRole: 47 AXRole: AXStatic 48 48 49 49 code 50 AXRole: 50 AXRole: AXStatic 51 51 52 52 del:not([datetime]) 53 AXRole: 53 AXRole: AXStatic 54 54 55 55 del[datetime] … … 204 204 205 205 ins:not([datetime]) 206 AXRole: 206 AXRole: AXStatic 207 207 208 208 ins[datetime] … … 348 348 349 349 samp 350 AXRole: 350 AXRole: AXStatic 351 351 352 352 section … … 441 441 442 442 var 443 AXRole: 443 AXRole: AXStatic 444 444 445 445 wbr -
trunk/Source/WebCore/ChangeLog
r199105 r199110 1 2016-04-06 Joanmarie Diggs <jdiggs@igalia.com> 2 3 REGRESSION(r195463): [GTK] accessibility/roles-computedRoleString.html and accessibility/roles-exposed.html failing 4 https://bugs.webkit.org/show_bug.cgi?id=153696 5 6 Reviewed by Chris Fleizach. 7 8 The failures were due to always mapping style format groups to GroupRole, even for 9 RenderInline objects. The fix is to expose inline style format groups as InlineRole, 10 add handling of GroupRole style groups to the ATK code, and InlineRole style groups 11 to the Mac code. 12 13 No new tests because we have sufficient coverage. Updated roles-computedRoleString.html 14 to reflect new exposure. 15 16 * accessibility/AccessibilityRenderObject.cpp: 17 (WebCore::AccessibilityRenderObject::determineAccessibilityRole): 18 * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: 19 (atkRole): 20 * accessibility/mac/AccessibilityObjectMac.mm: 21 (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): 22 * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: 23 (createAccessibilityRoleMap): 24 (-[WebAccessibilityObjectWrapper subrole]): 25 1 26 2016-04-06 Jer Noble <jer.noble@apple.com> 2 27 -
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
r198997 r199110 2594 2594 2595 2595 if (isStyleFormatGroup()) 2596 return GroupRole;2596 return is<RenderInline>(*m_renderer) ? InlineRole : GroupRole; 2597 2597 2598 2598 #if ENABLE(MATHML) -
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
r198254 r199110 591 591 return ATK_ROLE_APPLICATION; 592 592 case DocumentRegionRole: 593 case GroupRole:594 593 case RadioGroupRole: 595 594 case SVGRootRole: 596 595 case TabPanelRole: 597 596 return ATK_ROLE_PANEL; 597 case GroupRole: 598 return coreObject->isStyleFormatGroup() ? ATK_ROLE_SECTION : ATK_ROLE_PANEL; 598 599 case RowHeaderRole: 599 600 return ATK_ROLE_ROW_HEADER; -
trunk/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
r180718 r199110 93 93 return IgnoreObject; 94 94 95 if (roleValue() == InlineRole )95 if (roleValue() == InlineRole && !isStyleFormatGroup()) 96 96 return IgnoreObject; 97 97 -
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
r198427 r199110 2208 2208 { SVGTextRole, NSAccessibilityGroupRole }, 2209 2209 { SVGTSpanRole, NSAccessibilityGroupRole }, 2210 { InlineRole, NSAccessibilityGroupRole }, 2210 2211 }; 2211 2212 AccessibilityRoleMap& roleMap = *new AccessibilityRoleMap; … … 2395 2396 return NSAccessibilitySwitchSubrole; 2396 2397 2397 if ( role == GroupRole) {2398 if (m_object->isStyleFormatGroup()) { 2398 2399 if (Node* node = m_object->node()) { 2399 2400 if (node->hasTagName(kbdTag))
Note: See TracChangeset
for help on using the changeset viewer.