Changeset 199155 in webkit

Timestamp:

Apr 7, 2016 7:22:11 AM (8 years ago)

Author:

Antti Koivisto

Message:

FrameView::qualifiesAsVisuallyNonEmpty() returns false when loading a Google search results page before search results are loaded, even though the header is visible
​https://bugs.webkit.org/show_bug.cgi?id=156339
<rdar://problem/24491381>

Reviewed by Andreas Kling.

Jeff's testing indicates lowering the document height threshold improves things visually during page loading.

• page/FrameView.cpp:

(WebCore::FrameView::qualifiesAsVisuallyNonEmpty):

Lower document height threshold to from 200 to 48 pixels.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-07  Antti Koivisto  <antti@apple.com>
+
+        FrameView::qualifiesAsVisuallyNonEmpty() returns false when loading a Google search results page before search results are loaded, even though the header is visible
+        https://bugs.webkit.org/show_bug.cgi?id=156339
+        <rdar://problem/24491381>
+
+        Reviewed by Andreas Kling.
+
+        Patch by Jeff Miller.
+
+        Jeff's testing indicates lowering the document height threshold improves things visually during page loading.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
+
+            Lower document height threshold to from 200 to 48 pixels.
+
 2016-04-07  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -4258 +4258 @@
 
     // Require the document to grow a bit.
-    static const int documentHeightThreshold = 200;
+    // Using a value of 48 allows the header on Google's search page to render immediately before search results populate later.
+    static const int documentHeightThreshold = 48;
     LayoutRect overflowRect = documentElement->renderBox()->layoutOverflowRect();
     if (snappedIntRect(overflowRect).height() < documentHeightThreshold)