Changeset 19940 in webkit

Timestamp:

Mar 1, 2007 11:59:15 PM (17 years ago)

Author:

antti

Message:

LayoutTests:

Reviewed by Maciej.

HTTP layout test for ​http://bugs.webkit.org/show_bug.cgi?id=12690
REGRESSION: can not log in to bank of america with TOT webkit
<rdar://problem/4990044>

also for
​http://bugs.webkit.org/show_bug.cgi?id=12604
​http://bugs.webkit.org/show_bug.cgi?id=12020

• http/tests/misc/multiple-submit-expected.txt: Added.
• http/tests/misc/multiple-submit.html: Added.
• http/tests/misc/resources/post-echo-and-notify-done.cgi: Added.

WebCore:

Reviewed by Maciej.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12690
REGRESSION: can not log in to bank of america with TOT webkit
<rdar://problem/4990044>

and ​http://bugs.webkit.org/show_bug.cgi?id=12604
REGRESSION: After closing the "Would you like to save password" sheet, the form fails
to submit automatically at ​http://www.mac.com/WebObjects/HomePage.woa
<rdar://problem/4871752>

and ​http://bugs.webkit.org/show_bug.cgi?id=12020
REGRESSION: Flickr uploading broken
<rdar://problem/4928662>

Turn protection against multiple forms submission back on. This approach is buggy
but it is way better than not having it at all. Not protecting against this
breaks number of major sites.

• bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityPerformAction:]):
• loader/FrameLoader.cpp: (WebCore::FrameLoader::resetMultipleFormSubmissionProtection): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::receivedMainResourceError):
• loader/FrameLoader.h:
• page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
• page/Frame.cpp: (WebCore::Frame::setView):
• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::mouseDown):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/misc/multiple-submit-expected.txt (added)
• LayoutTests/http/tests/misc/multiple-submit.html (added)
• LayoutTests/http/tests/misc/resources/post-echo-and-notify-done.cgi (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bridge/mac/WebCoreAXObject.mm (modified) (1 diff)
• WebCore/loader/FrameLoader.cpp (modified) (5 diffs)
• WebCore/loader/FrameLoader.h (modified) (2 diffs)
• WebCore/page/EventHandler.cpp (modified) (2 diffs)
• WebCore/page/Frame.cpp (modified) (1 diff)
• WebCore/page/mac/EventHandlerMac.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-03-01  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Maciej.
+        
+        HTTP layout test for http://bugs.webkit.org/show_bug.cgi?id=12690
+        REGRESSION: can not log in to bank of america with TOT webkit
+        <rdar://problem/4990044>
+
+        also for
+        http://bugs.webkit.org/show_bug.cgi?id=12604
+        http://bugs.webkit.org/show_bug.cgi?id=12020
+        
+        * http/tests/misc/multiple-submit-expected.txt: Added.
+        * http/tests/misc/multiple-submit.html: Added.
+        * http/tests/misc/resources/post-echo-and-notify-done.cgi: Added.
+
 2007-03-01  Kevin McCullough  <kmccullough@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-03-01  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Maciej.
+        
+        Fix http://bugs.webkit.org/show_bug.cgi?id=12690
+        REGRESSION: can not log in to bank of america with TOT webkit
+        <rdar://problem/4990044>
+        
+        and http://bugs.webkit.org/show_bug.cgi?id=12604
+        REGRESSION: After closing the "Would you like to save password" sheet, the form fails 
+        to submit automatically at http://www.mac.com/WebObjects/HomePage.woa
+        <rdar://problem/4871752>
+        
+        and http://bugs.webkit.org/show_bug.cgi?id=12020
+        REGRESSION: Flickr uploading broken
+        <rdar://problem/4928662>
+        
+        Turn protection against multiple forms submission back on. This approach is buggy 
+        but it is way better than not having it at all. Not protecting against this
+        breaks number of major sites.
+        
+        * bridge/mac/WebCoreAXObject.mm:
+        (-[WebCoreAXObject accessibilityPerformAction:]):
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
+        (WebCore::FrameLoader::submitForm):
+        (WebCore::FrameLoader::receivedMainResourceError):
+        * loader/FrameLoader.h:
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::keyEvent):
+        * page/Frame.cpp:
+        (WebCore::Frame::setView):
+        * page/mac/EventHandlerMac.mm:
+        (WebCore::EventHandler::mouseDown):
+
 2007-03-01  Kevin McCullough  <kmccullough@apple.com>
 

trunk/WebCore/bridge/mac/WebCoreAXObject.mm

@@ -888 +888 @@
         if (!actionElement)
             return;
-#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
         if (Frame* f = actionElement->document()->frame())
             f->loader()->resetMultipleFormSubmissionProtection();
-#endif
         actionElement->accessKeyAction(true);
     }

trunk/WebCore/loader/FrameLoader.cpp

@@ -1465 +1465 @@
 }
 
-#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
 void FrameLoader::didNotOpenURL(const KURL& URL)
 {
@@ -1476 +1475 @@
     m_submittedFormURL = KURL();
 }
-#endif
 
 void FrameLoader::setEncoding(const String& name, bool userChosen)
@@ -2730 +2728 @@
 void FrameLoader::submitForm(const FrameLoadRequest& request, Event* event)
 {
-#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
     // FIXME: We'd like to remove this altogether and fix the multiple form submission issue another way.
     // We do not want to submit more than one form from the same page,
@@ -2747 +2744 @@
         m_submittedFormURL = request.resourceRequest().url();
     }
-#endif
 
     // FIXME: Why do we always pass true for userGesture?
@@ -3039 +3035 @@
     
     if (m_state == FrameStateProvisional) {
-#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
         KURL failedURL = m_provisionalDocumentLoader->originalRequestCopy().url();
         didNotOpenURL(failedURL);
-#endif
+            
         // We might have made a page cache item, but now we're bailing out due to an error before we ever
         // transitioned to the new page (before WebFrameState == commit).  The goal here is to restore any state

trunk/WebCore/loader/FrameLoader.h

@@ -339 +339 @@
         bool userGestureHint();
 
-#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
         void resetMultipleFormSubmissionProtection();
         void didNotOpenURL(const KURL&);
-#endif
 
         void addData(const char* bytes, int length);
@@ -580 +578 @@
         RefPtr<HTMLFormElement> m_formAboutToBeSubmitted;
         HashMap<String, String> m_formValuesAboutToBeSubmitted;
-#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
         KURL m_submittedFormURL;
-#endif
     
         Timer<FrameLoader> m_redirectionTimer;

trunk/WebCore/page/EventHandler.cpp

@@ -38 +38 @@
 #include "FocusController.h"
 #include "Frame.h"
+#include "FrameLoader.h"
 #include "FrameTree.h"
 #include "FrameView.h"
@@ -1258 +1259 @@
         return false;
     
-#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
     if (!keyEvent.isKeyUp())
-        loader()->resetMultipleFormSubmissionProtection();
-#endif
+        m_frame->loader()->resetMultipleFormSubmissionProtection();
 
     result = !node->dispatchKeyEvent(keyEvent);

trunk/WebCore/page/Frame.cpp

@@ -276 +276 @@
     d->m_view = view;
 
-#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
     // Only one form submission is allowed per view of a part.
     // Since this part may be getting reused as a result of being
     // pulled from the back/forward cache, reset this flag.
     loader()->resetMultipleFormSubmissionProtection();
-#endif
 }
 

trunk/WebCore/page/mac/EventHandlerMac.mm

@@ -456 +456 @@
 
     BEGIN_BLOCK_OBJC_EXCEPTIONS;
-#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
+    
     m_frame->loader()->resetMultipleFormSubmissionProtection();
-#endif
+
     m_mouseDownView = nil;
     dragState().m_dragSrc = 0;