Changeset 199607 in webkit

Timestamp:

Apr 15, 2016 12:59:20 PM (8 years ago)

Author:

mmaxfield@apple.com

Message:

ASSERT when loading github.com
​https://bugs.webkit.org/show_bug.cgi?id=156604
<rdar://problem/19890634>

Reviewed by Darin Adler.

Source/WebCore:

HTMLFormControlElement::m_isValid is a cache of the results of the valid() function.
When cloning the node, we were preserving each individual item, but not the state
of the cache. Therefore, the cache and the attributes didn't agree with each other.

Test: fast/forms/checkValidity-cloneNode-crash.html

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement):

LayoutTests:

• fast/forms/checkValidity-cloneNode-crash-expected.txt: Added.
• fast/forms/checkValidity-cloneNode-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/checkValidity-cloneNode-crash-expected.txt (added)
• LayoutTests/fast/forms/checkValidity-cloneNode-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLInputElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-04-15  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        ASSERT when loading github.com
+        https://bugs.webkit.org/show_bug.cgi?id=156604
+        <rdar://problem/19890634>
+
+        Reviewed by Darin Adler.
+
+        * fast/forms/checkValidity-cloneNode-crash-expected.txt: Added.
+        * fast/forms/checkValidity-cloneNode-crash.html: Added.
+
 2016-04-15  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-15  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        ASSERT when loading github.com
+        https://bugs.webkit.org/show_bug.cgi?id=156604
+        <rdar://problem/19890634>
+
+        Reviewed by Darin Adler.
+
+        HTMLFormControlElement::m_isValid is a cache of the results of the valid() function.
+        When cloning the node, we were preserving each individual item, but not the state
+        of the cache. Therefore, the cache and the attributes didn't agree with each other.
+
+        Test: fast/forms/checkValidity-cloneNode-crash.html
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement):
+
 2016-04-15  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -922 +922 @@
     HTMLTextFormControlElement::copyNonAttributePropertiesFromElement(source);
 
+    updateValidity();
     setFormControlValueMatchesRenderer(false);
     m_inputType->updateInnerTextValue();