Changeset 199653 in webkit

Timestamp:

Apr 18, 2016 12:40:22 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=156621

Reviewed by Martin Robinson.

This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.

• TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:

(testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
+        https://bugs.webkit.org/show_bug.cgi?id=156621
+
+        Reviewed by Martin Robinson.
+
+        This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
+        scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
+        simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
+
+        * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
+        (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
+
 2016-04-17  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
 

trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp

@@ -615 +615 @@
         " <a style='position:absolute; left:1; top:20' href='http://www.webkitgtk.org/logo' title='WebKitGTK+ Logo'><img src='0xdeadbeef' width=5 height=5></img></a>"
         " <input style='position:absolute; left:1; top:30' size='10'></input>"
-        " <div style='position:absolute; left:1; top:50; width:30; height:30; overflow:scroll'>&nbsp;</div>"
         " <video style='position:absolute; left:1; top:100' width='300' height='300' controls='controls' preload='none'><source src='movie.ogg' type='video/ogg' /></video>"
         " <p style='position:absolute; left:1; top:120' id='text_to_select'>Lorem ipsum.</p>"
@@ -691 +690 @@
 
     // Move over scrollbar.
-    hitTestResult = test->moveMouseAndWaitUntilMouseTargetChanged(5, 75);
+    hitTestResult = test->moveMouseAndWaitUntilMouseTargetChanged(gtk_widget_get_allocated_width(GTK_WIDGET(test->m_webView)) - 4, 5);
     g_assert(!webkit_hit_test_result_context_is_link(hitTestResult));
     g_assert(!webkit_hit_test_result_context_is_image(hitTestResult));