Changeset 199715 in webkit
- Timestamp:
- Apr 19, 2016 2:50:26 AM (8 years ago)
- Location:
- trunk
- Files:
-
- 1 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r199714 r199715 1 2016-04-19 Joanmarie Diggs <jdiggs@igalia.com> 2 3 [GTK] accessibility/gtk/entry-and-password.html is failing since r194847 4 https://bugs.webkit.org/show_bug.cgi?id=153062 5 6 Reviewed by Carlos Garcia Campos. 7 8 The auto-fill-crash.html test has expectations which include the children 9 count for the text input. These expectations were incorrect for ATK where 10 accessible text inputs lack accessible text children. 11 12 * accessibility/auto-fill-crash.html: Modified to take platform into account. 13 * platform/gtk/TestExpectations: Unskipped entry-and-password.html. 14 * platform/gtk/accessibility/auto-fill-crash-expected.txt: Added. 15 1 16 2016-04-19 Carlos Garcia Campos <cgarcia@igalia.com> 2 17 -
trunk/LayoutTests/accessibility/auto-fill-crash.html
r198769 r199715 18 18 if (window.accessibilityController) { 19 19 var axTextField = accessibilityController.accessibleElementById("textfield"); 20 var childrenCountExpected = accessibilityController.platformName == "atk" ? "2" : "3"; 20 21 window.internals.setShowAutoFillButton(document.getElementById("textfield"), "AutoFillButtonTypeContacts"); 21 shouldBe("accessibilityController.accessibleElementById('textfield').childrenCount", "3");22 shouldBe("accessibilityController.accessibleElementById('textfield').childrenCount", childrenCountExpected); 22 23 23 24 // Don't crash! 25 childrenCountExpected = accessibilityController.platformName == "atk" ? "0" : "1"; 24 26 window.internals.setShowAutoFillButton(document.getElementById("textfield"), "AutoFillButtonTypeNone"); 25 shouldBe("accessibilityController.accessibleElementById('textfield').childrenCount", "1");27 shouldBe("accessibilityController.accessibleElementById('textfield').childrenCount", childrenCountExpected); 26 28 } 27 29 -
trunk/LayoutTests/platform/gtk/TestExpectations
r199703 r199715 2523 2523 webkit.org/b/152908 pageoverlay/overlay-small-frame-paints.html [ Failure ] 2524 2524 2525 webkit.org/b/153062 accessibility/gtk/entry-and-password.html [ Failure ]2526 2527 2525 webkit.org/b/153602 fast/table/003.html [ Failure ] 2528 2526 webkit.org/b/153602 fast/text/emoji.html [ Failure ] -
trunk/Source/WebCore/ChangeLog
r199708 r199715 1 2016-04-19 Joanmarie Diggs <jdiggs@igalia.com> 2 3 [GTK] accessibility/gtk/entry-and-password.html is failing since r194847 4 https://bugs.webkit.org/show_bug.cgi?id=153062 5 6 Reviewed by Carlos Garcia Campos. 7 8 The changes in r194847 include using WebCore's rendering for the CapsLock indicator. 9 As a side effect, password inputs gained a TextControlInnerTextElement child from 10 the Shadow DOM. If we include that child in the accessibility tree, the child will 11 emit focus and text notifications that suggest the user is no longer in the control. 12 This can be especially problematic for screen reader users with key echo enabled 13 when typing in a password input. To fix this, prune TextControlInnerTextElement 14 children from the accessibility tree for ATK. 15 16 No new tests as existing coverage caught this regression. Also modified the 17 auto-fill-crash.html test whose expectations include the children count for 18 a text input. 19 20 * accessibility/atk/AccessibilityObjectAtk.cpp: 21 (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): 22 1 23 2016-04-18 Brady Eidson <beidson@apple.com> 2 24 -
trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp
r184213 r199715 25 25 #include "HTMLNames.h" 26 26 #include "RenderText.h" 27 #include "TextControlInnerElements.h" 27 28 #include <glib-object.h> 28 29 … … 95 96 Node* node = renderObject->node(); 96 97 if (node && node->hasTagName(HTMLNames::spanTag) && !canSetFocusAttribute() && !hasAttributesRequiredForInclusion()) 98 return IgnoreObject; 99 100 // If we include TextControlInnerTextElement children, changes to those children 101 // will result in focus and text notifications that suggest the user is no longer 102 // in the control. This can be especially problematic for screen reader users with 103 // key echo enabled when typing in a password input. 104 if (is<TextControlInnerTextElement>(node)) 97 105 return IgnoreObject; 98 106
Note: See TracChangeset
for help on using the changeset viewer.