Changeset 199807 in webkit
- Timestamp:
- Apr 20, 2016 10:02:23 PM (8 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r199804 r199807 1 2016-04-20 Chris Dumez <cdumez@apple.com> 2 3 Crash under WebCore::TextIterator::subrange() 4 https://bugs.webkit.org/show_bug.cgi?id=156809 5 <rdar://problem/21102730> 6 7 Reviewed by Ryosuke Niwa. 8 9 TextIterator::rangeFromLocationAndLength() may return null. However, we 10 failed to do a null check before calling TextIterator::subrange() with 11 that range. 12 13 No new tests, do not know how to reproduce. 14 15 * editing/AlternativeTextController.cpp: 16 (WebCore::AlternativeTextController::applyAlternativeTextToRange): 17 1 18 2016-04-20 Brady Eidson <beidson@apple.com> 2 19 -
trunk/Source/WebCore/editing/AlternativeTextController.cpp
r198306 r199807 274 274 // Recalculate pragraphRangeContainingCorrection, since SpellingCorrectionCommand modified the DOM, such that the original paragraphRangeContainingCorrection is no longer valid. Radar: 10305315 Bugzilla: 89526 275 275 paragraphRangeContainingCorrection = TextIterator::rangeFromLocationAndLength(&rootNode, paragraphStartIndex, correctionStartOffsetInParagraph + alternative.length()); 276 if (!paragraphRangeContainingCorrection) 277 return; 276 278 277 279 setEnd(paragraphRangeContainingCorrection.get(), m_frame.selection().selection().start());
Note: See TracChangeset
for help on using the changeset viewer.