Changeset 199816 in webkit

Timestamp:

Apr 21, 2016 8:42:44 AM (8 years ago)

Author:

Chris Dumez

Message:

Drop [UsePointersEvenForNonNullableObjectArguments] from DOMURL
​https://bugs.webkit.org/show_bug.cgi?id=156797

Reviewed by Youenn Fablet.

• html/DOMURL.cpp:

(WebCore::DOMURL::create):

• html/DOMURL.h:
• html/DOMURL.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/DOMURL.cpp (modified) (1 diff)
• html/DOMURL.h (modified) (1 diff)
• html/DOMURL.idl (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-21  Chris Dumez  <cdumez@apple.com>
+
+        Drop [UsePointersEvenForNonNullableObjectArguments] from DOMURL
+        https://bugs.webkit.org/show_bug.cgi?id=156797
+
+        Reviewed by Youenn Fablet.
+
+        * html/DOMURL.cpp:
+        (WebCore::DOMURL::create):
+        * html/DOMURL.h:
+        * html/DOMURL.idl:
+
 2016-04-21  Claudio Saavedra  <csaavedra@igalia.com>
 

trunk/Source/WebCore/html/DOMURL.cpp

@@ -44 +44 @@
 }
 
-Ref<DOMURL> DOMURL::create(const String& url, const DOMURL* base, ExceptionCode& ec)
+Ref<DOMURL> DOMURL::create(const String& url, const DOMURL& base, ExceptionCode& ec)
 {
-    ASSERT(base);
-    return adoptRef(*new DOMURL(url, *base, ec));
+    return adoptRef(*new DOMURL(url, base, ec));
 }
 

trunk/Source/WebCore/html/DOMURL.h

@@ -45 +45 @@
 public:
     static Ref<DOMURL> create(const String& url, const String& base, ExceptionCode&);
-    static Ref<DOMURL> create(const String& url, const DOMURL* base, ExceptionCode&);
+    static Ref<DOMURL> create(const String& url, const DOMURL& base, ExceptionCode&);
     static Ref<DOMURL> create(const String& url, ExceptionCode&);
 

trunk/Source/WebCore/html/DOMURL.idl

@@ -31 +31 @@
     Constructor(DOMString url, DOMURL base),
     ConstructorRaisesException,
-    UsePointersEvenForNonNullableObjectArguments,
     JSGenerateToNativeObject,
     JSGenerateToJSObject,
@@ -38 +37 @@
     ExportMacro=WEBCORE_EXPORT,
 ] interface DOMURL {
-    [CallWith=ScriptExecutionContext] static DOMString? createObjectURL(Blob? blob);
+    [CallWith=ScriptExecutionContext] static DOMString? createObjectURL(Blob? blob); // FIXME: The return value and the parameter should not be nullable.
     [CallWith=ScriptExecutionContext] static void revokeObjectURL(DOMString url);
 };