Changeset 199947 in webkit


Ignore:
Timestamp:
Apr 22, 2016 7:49:40 PM (8 years ago)
Author:
Matt Baker
Message:

Web Inspector: HeapAllocationsTimeline grid should use built-in grid column icons
https://bugs.webkit.org/show_bug.cgi?id=156934

Reviewed by Timothy Hatcher.

  • UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:

(WebInspector.HeapAllocationsTimelineDataGridNode):
Use existing base class helper function to create main title text.
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
Add icon class names to cell, remove icon element.

  • UserInterface/Views/HeapAllocationsTimelineView.js:

(WebInspector.HeapAllocationsTimelineView):
Turn on icons for the column.

Location:
trunk/Source/WebInspectorUI
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r199899 r199947  
     12016-04-22  Matt Baker  <mattbaker@apple.com>
     2
     3        Web Inspector: HeapAllocationsTimeline grid should use built-in grid column icons
     4        https://bugs.webkit.org/show_bug.cgi?id=156934
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        * UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:
     9        (WebInspector.HeapAllocationsTimelineDataGridNode):
     10        Use existing base class helper function to create main title text.
     11        (WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
     12        Add icon class names to cell, remove icon element.
     13
     14        * UserInterface/Views/HeapAllocationsTimelineView.js:
     15        (WebInspector.HeapAllocationsTimelineView):
     16        Turn on icons for the column.
     17
    1182016-04-22  Timothy Hatcher  <timothy@apple.com>
    219
  • trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineDataGridNode.js

    r198786 r199947  
    3434
    3535        this._data = {
    36             name: WebInspector.TimelineTabContentView.displayNameForRecord(heapAllocationsTimelineRecord),
     36            name: this.displayName(),
    3737            timestamp: this._record.timestamp - zeroTime,
    3838            size: this._record.heapSnapshot.totalSize,
     
    4949        switch (columnIdentifier) {
    5050        case "name":
     51            cell.classList.add(...this.iconClassNames());
     52
    5153            let fragment = document.createDocumentFragment();
    52             let iconElement = fragment.appendChild(document.createElement("img"));
    53             iconElement.classList.add("icon", "heap-snapshot");
    5454            let titleElement = fragment.appendChild(document.createElement("span"));
    5555            titleElement.textContent = this._data.name;
  • trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js

    r199634 r199947  
    3838                title: WebInspector.UIString("Name"),
    3939                width: "150px",
     40                icon: true,
    4041            },
    4142            timestamp: {
Note: See TracChangeset for help on using the changeset viewer.