Changeset 19995 in webkit

Timestamp:

Mar 6, 2007 7:15:26 PM (17 years ago)

Author:

bdash

Message:

2007-03-06 Ian Eng <​ian.eng.webkit@gmail.com>

Reviewed by Maciej.

• fixed ​http://bugs.webkit.org/show_bug.cgi?id=12720 Bug 12720: Re-defining window.location.toString function keeps re-loading forever

• bindings/js/kjs_window.cpp: Disallow replacing functions in LocationTable, and return early without updating URL.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/kjs_window.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-03-06  Ian Eng <ian.eng.webkit@gmail.com>
+
+        Reviewed by Maciej.
+
+        - fixed http://bugs.webkit.org/show_bug.cgi?id=12720
+        Bug 12720: Re-defining window.location.toString function keeps re-loading forever
+
+        * bindings/js/kjs_window.cpp:
+        Disallow replacing functions in LocationTable, and return early without updating URL.
+
 2007-03-06  Kevin McCullough  <kmccullough@apple.com>
 

trunk/WebCore/bindings/js/kjs_window.cpp

@@ -2215 +2215 @@
       url.setQuery(str);
       break;
+    default:
+      // Disallow changing other properties in LocationTable. e.g., "window.location.toString = ...".
+      // <http://bugs.webkit.org/show_bug.cgi?id=12720>
+      return;
     }
   else {