Changeset 199986 in webkit

Timestamp:

Apr 25, 2016 3:26:53 AM (8 years ago)

Author:

youenn.fablet@crf.canon.fr

Message:

Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack
​https://bugs.webkit.org/show_bug.cgi?id=156899

Reviewed by Chris Dumez.

No behavior changes.

• html/track/TextTrack.idl: Marking cue and region parameter as nullable.

Also marking cues and activeCues as nullable attributes.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/track/TextTrack.idl (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
+
+        Drop [UsePointersEvenForNonNullableObjectArguments] from TextTrack
+        https://bugs.webkit.org/show_bug.cgi?id=156899
+
+        Reviewed by Chris Dumez.
+
+        No behavior changes.
+
+        * html/track/TextTrack.idl: Marking cue and region parameter as nullable.
+        Also marking cues and activeCues as nullable attributes.
+
 2016-04-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 

trunk/Source/WebCore/html/track/TextTrack.idl

@@ -29 +29 @@
 [
     Conditional=VIDEO_TRACK,
-    UsePointersEvenForNonNullableObjectArguments,
     GenerateIsReachable=ImplElementRoot,
     JSCustomMarkFunction,
@@ -42 +41 @@
     attribute TextTrackMode mode;
 
-    readonly attribute TextTrackCueList cues;
-    readonly attribute TextTrackCueList activeCues;
+    readonly attribute TextTrackCueList? cues;
+    readonly attribute TextTrackCueList? activeCues;
 
-    [RaisesException] void addCue(TextTrackCue cue);
-    [RaisesException] void removeCue(TextTrackCue cue);
+    // FIXME: cue parameter should not be nullable in addCue and removeCue.
+    [RaisesException] void addCue(TextTrackCue? cue);
+    [RaisesException] void removeCue(TextTrackCue? cue);
 
     attribute EventHandler oncuechange;
@@ -52 +52 @@
 #if !defined(LANGUAGE_GOBJECT) || !LANGUAGE_GOBJECT // Work around shortcomings in the gobject binding generator handling of conditional features by turning these off for gobject.
     readonly attribute VTTRegionList regions;
-    void addRegion(VTTRegion region);
-    [RaisesException] void removeRegion(VTTRegion region);
+    // FIXME: region parameter should not be nullable in addRegion and removeRegion.
+    void addRegion(VTTRegion? region);
+    [RaisesException] void removeRegion(VTTRegion? region);
 #endif
 };