Changeset 200040 in webkit

Timestamp:

Apr 25, 2016 12:43:55 PM (8 years ago)

Author:

dbates@webkit.org

Message:

Unreviewed, rolling out r199916.
​https://bugs.webkit.org/show_bug.cgi?id=156989

Might break buildbot when master is restarted (Requested by
Srinivasan Vijayaraghava, Guest100, on #webkit).

Reverted changeset:

"Add JSC test results in json format to a buildbot log"
​https://bugs.webkit.org/show_bug.cgi?id=156920
​http://trac.webkit.org/changeset/199916

Patch by Commit Queue <​commit-queue@webkit.org> on 2016-04-25

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/master.cfg (modified) (3 diffs)
• ChangeLog (modified) (1 diff)
• Scripts/run-javascriptcore-tests (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

@@ -45 +45 @@
 c['status'] = []
 c['status'].append(html.WebStatus(http_port=8710,
-                                  revlink="https://trac.webkit.org/changeset/%s",
+                                  revlink="https://trac.webkit.org/changeset/%s", 
                                   changecommentlink=(r"(https://bugs\.webkit\.org/show_bug\.cgi\?id=|webkit\.org/b/)(\d+)", r"https://bugs.webkit.org/show_bug.cgi?id=\2"),
                                   authz=authz))
@@ -229 +229 @@
     def createSummary(self, log):
         platform = self.getProperty('platform')
-        if platform.startswith('mac'):
+        if platform.startswith('mac'):    
             warnings = []
             errors = []
@@ -299 +299 @@
     description = ["jscore-tests running"]
     descriptionDone = ["jscore-tests"]
-    _jsonFileName = "jsc_test_failures.json"
-    command = ["perl", "./Tools/Scripts/run-javascriptcore-tests", "--no-build", WithProperties("--%(configuration)s", "--json-output=%(_jsonFileName)s")]
+    command = ["perl", "./Tools/Scripts/run-javascriptcore-tests", "--no-build", WithProperties("--%(configuration)s")]
     failedTestsFormatString = "%d JSC test%s failed"
-    logfiles = {"json": _jsonFileName}
 
     def start(self):

trunk/Tools/ChangeLog

@@ +1 @@
+2016-04-25  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r199916.
+        https://bugs.webkit.org/show_bug.cgi?id=156989
+
+        Might break buildbot when master is restarted (Requested by
+        Srinivasan Vijayaraghava, Guest100, on #webkit).
+
+        Reverted changeset:
+
+        "Add JSC test results in json format to a buildbot log"
+        https://bugs.webkit.org/show_bug.cgi?id=156920
+        http://trac.webkit.org/changeset/199916
+
 2016-04-23  Chris Dumez  <cdumez@apple.com>
 

trunk/Tools/Scripts/run-javascriptcore-tests

@@ -333 +333 @@
     if (defined($jsonFileName)) {
         my %jsonData = (
-            "failures" => \@jscStressFailList,
+            "numJSCStressFailures" => $numJSCStressFailures,
+            "jscStressFailList" => \@jscStressFailList,
         );