Changeset 200054 in webkit

Timestamp:

Apr 25, 2016 3:40:45 PM (8 years ago)

Author:

n_wang@apple.com

Message:

AX: Crash at -[WebAccessibilityObjectWrapper accessibilityAttributeValue:] + 4391
​https://bugs.webkit.org/show_bug.cgi?id=156987

Reviewed by Chris Fleizach.

Source/WebCore:

When we hit test on a slider indicator asking for the value when the parent slider's
accessibility object is not created or the parent slider has been removed, it will cause
crash. Fixed it by adding a check to see if the object is detached from the parent.

Test: accessibility/mac/slider-thumb-value-crash.html

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

• accessibility/mac/slider-thumb-value-crash-expected.txt: Added.
• accessibility/mac/slider-thumb-value-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/mac/slider-thumb-value-crash-expected.txt (added)
• LayoutTests/accessibility/mac/slider-thumb-value-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-04-25  Nan Wang  <n_wang@apple.com>
+
+        AX: Crash at -[WebAccessibilityObjectWrapper accessibilityAttributeValue:] + 4391
+        https://bugs.webkit.org/show_bug.cgi?id=156987
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/mac/slider-thumb-value-crash-expected.txt: Added.
+        * accessibility/mac/slider-thumb-value-crash.html: Added.
+
 2016-04-25  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-25  Nan Wang  <n_wang@apple.com>
+
+        AX: Crash at -[WebAccessibilityObjectWrapper accessibilityAttributeValue:] + 4391
+        https://bugs.webkit.org/show_bug.cgi?id=156987
+
+        Reviewed by Chris Fleizach.
+
+        When we hit test on a slider indicator asking for the value when the parent slider's
+        accessibility object is not created or the parent slider has been removed, it will cause
+        crash. Fixed it by adding a check to see if the object is detached from the parent. 
+
+        Test: accessibility/mac/slider-thumb-value-crash.html
+
+        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+        (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
+
 2016-04-25  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

@@ -2562 +2562 @@
         return nil;
     
+    if (m_object->isDetachedFromParent())
+        return nil;
+    
     if ([attributeName isEqualToString: NSAccessibilityRoleAttribute])
         return [self role];