Changeset 200069 in webkit

Timestamp:

Apr 25, 2016 8:52:08 PM (8 years ago)

Author:

mmaxfield@apple.com

Message:

Cloning a textarea does not clone the textarea's value
​https://bugs.webkit.org/show_bug.cgi?id=156637

Reviewed by Chris Dumez.

​https://dom.spec.whatwg.org/#concept-node-clone describes that the value
of a node shouldn't be copied when cloning the node.

• fast/forms/checkValidity-cloneNode-crash-expected.txt:
• fast/forms/checkValidity-cloneNode-crash.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/forms/checkValidity-cloneNode-crash-expected.txt (modified) (1 diff)
• fast/forms/checkValidity-cloneNode-crash.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Cloning a textarea does not clone the textarea's value
+        https://bugs.webkit.org/show_bug.cgi?id=156637
+
+        Reviewed by Chris Dumez.
+
+        https://dom.spec.whatwg.org/#concept-node-clone describes that the value
+        of a node shouldn't be copied when cloning the node.
+
+        * fast/forms/checkValidity-cloneNode-crash-expected.txt:
+        * fast/forms/checkValidity-cloneNode-crash.html:
+
 2016-04-25  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/LayoutTests/fast/forms/checkValidity-cloneNode-crash-expected.txt

@@ -11 +11 @@
 PASS element2.checkValidity() is false
 PASS element.checkValidity() is true
+PASS element2.value is ""
+PASS element2.checkValidity() is false
 PASS element2.checkValidity() is true
 PASS successfullyParsed is true

trunk/LayoutTests/fast/forms/checkValidity-cloneNode-crash.html

@@ -45 +45 @@
     shouldBeTrue("element.checkValidity()");
     element2 = element.cloneNode();
-    // https://bugs.webkit.org/show_bug.cgi?id=156637 will fix this bug.
-    // shouldBeTrue("element2.checkValidity()");
+    shouldBeEqualToString("element2.value", "");
+    shouldBeFalse("element2.checkValidity()");
     element2.value = element.value;
     shouldBeTrue("element2.checkValidity()");