Changeset 200100 in webkit

Timestamp:

Apr 26, 2016 11:27:08 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[curl] Requests interrupted when using https via proxy
​https://bugs.webkit.org/show_bug.cgi?id=157028

Patch by Fujii Hironori <Fujii Hironori> on 2016-04-26
Reviewed by Alex Christensen.

A proxy responds "200 Connection Established" to a CONNECT
method. This response doesn't have Content-Type, then the
request is canceled due to a unsupported MIME type. This is not
a real response from the recipient server. It should not be
processed normally. Just ignore the response.

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::headerCallback):
Do nothing if httpCode is 0. This is the case of "200 Connection Established".

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/curl/ResourceHandleManager.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-04-26  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [curl] Requests interrupted when using https via proxy
+        https://bugs.webkit.org/show_bug.cgi?id=157028
+
+        Reviewed by Alex Christensen.
+
+        A proxy responds "200 Connection Established" to a CONNECT
+        method.  This response doesn't have Content-Type, then the
+        request is canceled due to a unsupported MIME type. This is not
+        a real response from the recipient server. It should not be
+        processed normally. Just ignore the response.
+
+        * platform/network/curl/ResourceHandleManager.cpp:
+        (WebCore::headerCallback):
+        Do nothing if httpCode is 0. This is the case of "200 Connection Established".
+
 2016-04-26  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/network/curl/ResourceHandleManager.cpp

@@ -483 +483 @@
         curl_easy_getinfo(h, CURLINFO_RESPONSE_CODE, &httpCode);
 
+        if (!httpCode) {
+            // Comes here when receiving 200 Connection Established. Just return.
+            return totalSize;
+        }
         if (isHttpInfo(httpCode)) {
             // Just return when receiving http info, e.g. HTTP/1.1 100 Continue.