Changeset 200119 in webkit

Timestamp:

Apr 26, 2016 7:14:35 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Uncaught Exception: SecurityError: DOM Exception 18: An attempt was made to break through the security policy of the user agent.
​https://bugs.webkit.org/show_bug.cgi?id=156991
<rdar://problem/25913475>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-04-26
Reviewed by Timothy Hatcher.

Source/WebKit/mac:

• WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController init]):
Apply the same universal file access to WebKit1 Web Inspector views that
we apply to WebKit2 views. Explicitly always allow access to storage
for Web Inspector content just in case as we already allow universal
file access.

Source/WebKit2:

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Explicitly always allow access to storage for Web Inspector content just
in case, as we already allow universal file access.

Location:

trunk/Source

Files:

• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebCoreSupport/WebInspectorClient.mm (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (modified) (1 diff)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2016-04-26  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Uncaught Exception: SecurityError: DOM Exception 18: An attempt was made to break through the security policy of the user agent.
+        https://bugs.webkit.org/show_bug.cgi?id=156991
+        <rdar://problem/25913475>
+
+        Reviewed by Timothy Hatcher.
+
+        * WebCoreSupport/WebInspectorClient.mm:
+        (-[WebInspectorWindowController init]):
+        Apply the same universal file access to WebKit1 Web Inspector views that
+        we apply to WebKit2 views. Explicitly always allow access to storage
+        for Web Inspector content just in case as we already allow universal
+        file access.
+
 2016-04-26  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm

@@ -388 +388 @@
     [preferences setTabsToLinks:NO];
     [preferences setUserStyleSheetEnabled:NO];
+    [preferences setAllowFileAccessFromFileURLs:YES];
+    [preferences setAllowUniversalAccessFromFileURLs:YES];
+    [preferences setStorageBlockingPolicy:WebAllowAllStorage];
 
     _frontendWebView = [[WebView alloc] init];

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-04-26  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Uncaught Exception: SecurityError: DOM Exception 18: An attempt was made to break through the security policy of the user agent.
+        https://bugs.webkit.org/show_bug.cgi?id=156991
+        <rdar://problem/25913475>
+
+        Reviewed by Timothy Hatcher.
+
+        * UIProcess/mac/WebInspectorProxyMac.mm:
+        (WebKit::WebInspectorProxy::platformCreateInspectorPage):
+        Explicitly always allow access to storage for Web Inspector content just
+        in case, as we already allow universal file access.
+
 2016-04-26  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm

@@ -374 +374 @@
     preferences._allowFileAccessFromFileURLs = YES;
     [configuration _setAllowUniversalAccessFromFileURLs:YES];
+    preferences._storageBlockingPolicy = _WKStorageBlockingPolicyAllowAll;
     preferences._javaScriptRuntimeFlags = 0;
     if (isUnderTest()) {