Changeset 200126 in webkit
- Timestamp:
- Apr 27, 2016 6:14:05 AM (8 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r200118 r200126 1 2016-04-27 Hunseop Jeong <hs85.jeong@samsung.com> 2 3 [EFL][GTK] Volume slider only changes volume when thumb is released, not while dragging 4 https://bugs.webkit.org/show_bug.cgi?id=156970 5 6 Reviewed by Xabier Rodriguez-Calvar. 7 8 Removed the passed test. 9 10 * platform/efl/TestExpectations: 11 * platform/gtk/TestExpectations: 12 1 13 2016-04-26 Dean Jackson <dino@apple.com> 2 14 -
trunk/LayoutTests/platform/efl/TestExpectations
r199975 r200126 2683 2683 webkit.org/b/156969 media/video-playing-and-pause.html [ Failure ] 2684 2684 webkit.org/b/156969 media/video-restricted-no-preload-auto.html [ Failure ] 2685 webkit.org/b/156969 media/video-volume-slider-drag.html [ Failure ]2686 2685 webkit.org/b/156969 media/video-zoom-controls.html [ Failure ] 2687 2686 webkit.org/b/156969 media/volume-bar-empty-when-muted.html [ Failure ] -
trunk/LayoutTests/platform/gtk/TestExpectations
r199876 r200126 2325 2325 2326 2326 webkit.org/b/137695 media/video-controls-audiotracks-trackmenu.html [ Failure ] 2327 webkit.org/b/138074 media/video-volume-slider-drag.html [ Failure ]2328 2327 2329 2328 # Font is clipped incorrectly -
trunk/Source/WebCore/ChangeLog
r200123 r200126 1 2016-04-27 Hunseop Jeong <hs85.jeong@samsung.com> 2 3 [EFL][GTK] Volume slider only changes volume when thumb is released, not while dragging 4 https://bugs.webkit.org/show_bug.cgi?id=156970 5 6 Reviewed by Xabier Rodriguez-Calvar. 7 8 Volume slider have to change the volume while dragging the thumb. 9 10 Test: media/video-volume-slider-drag.html 11 12 * Modules/mediacontrols/mediaControlsBase.js: 13 (Controller.prototype.createControls): Use the 'input' event instead of the 'change' to 14 check the changed value correctly. 15 (Controller.prototype.handleMaxButtonClicked): 16 (Controller.prototype.handleVolumeSliderInput): Renamed from handleVolumeSliderChange. 17 (Controller.prototype.handleVolumeSliderChange): Deleted. 18 1 19 2016-04-27 Youenn Fablet <youenn.fablet@crf.canon.fr> 2 20 -
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js
r195809 r200126 391 391 volume.max = 1; 392 392 volume.step = .01; 393 this.listenFor(volume, ' change', this.handleVolumeSliderChange);393 this.listenFor(volume, 'input', this.handleVolumeSliderInput); 394 394 395 395 var captionButton = this.controls.captionButton = document.createElement('button'); … … 821 821 }, 822 822 823 handleVolumeSlider Change: function(event)823 handleVolumeSliderInput: function(event) 824 824 { 825 825 if (this.video.muted) {
Note: See TracChangeset
for help on using the changeset viewer.