Changeset 200126 in webkit


Ignore:
Timestamp:
Apr 27, 2016 6:14:05 AM (8 years ago)
Author:
Hunseop Jeong
Message:

[EFL][GTK] Volume slider only changes volume when thumb is released, not while dragging
https://bugs.webkit.org/show_bug.cgi?id=156970

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Volume slider have to change the volume while dragging the thumb.

Test: media/video-volume-slider-drag.html

  • Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.createControls): Use the 'input' event instead of the 'change' to
check the changed value correctly.
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.handleVolumeSliderInput): Renamed from handleVolumeSliderChange.
(Controller.prototype.handleVolumeSliderChange): Deleted.

LayoutTests:

Removed the passed test.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r200118 r200126  
     12016-04-27  Hunseop Jeong  <hs85.jeong@samsung.com>
     2
     3        [EFL][GTK] Volume slider only changes volume when thumb is released, not while dragging
     4        https://bugs.webkit.org/show_bug.cgi?id=156970
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        Removed the passed test.
     9
     10        * platform/efl/TestExpectations:
     11        * platform/gtk/TestExpectations:
     12
    1132016-04-26  Dean Jackson  <dino@apple.com>
    214
  • trunk/LayoutTests/platform/efl/TestExpectations

    r199975 r200126  
    26832683webkit.org/b/156969 media/video-playing-and-pause.html [ Failure ]
    26842684webkit.org/b/156969 media/video-restricted-no-preload-auto.html [ Failure ]
    2685 webkit.org/b/156969 media/video-volume-slider-drag.html [ Failure ]
    26862685webkit.org/b/156969 media/video-zoom-controls.html [ Failure ]
    26872686webkit.org/b/156969 media/volume-bar-empty-when-muted.html [ Failure ]
  • trunk/LayoutTests/platform/gtk/TestExpectations

    r199876 r200126  
    23252325
    23262326webkit.org/b/137695 media/video-controls-audiotracks-trackmenu.html [ Failure ]
    2327 webkit.org/b/138074 media/video-volume-slider-drag.html [ Failure ]
    23282327
    23292328# Font is clipped incorrectly
  • trunk/Source/WebCore/ChangeLog

    r200123 r200126  
     12016-04-27  Hunseop Jeong  <hs85.jeong@samsung.com>
     2
     3        [EFL][GTK] Volume slider only changes volume when thumb is released, not while dragging
     4        https://bugs.webkit.org/show_bug.cgi?id=156970
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        Volume slider have to change the volume while dragging the thumb.
     9
     10        Test: media/video-volume-slider-drag.html
     11
     12        * Modules/mediacontrols/mediaControlsBase.js:
     13        (Controller.prototype.createControls): Use the 'input' event instead of the 'change' to
     14        check the changed value correctly.
     15        (Controller.prototype.handleMaxButtonClicked):
     16        (Controller.prototype.handleVolumeSliderInput): Renamed from handleVolumeSliderChange.
     17        (Controller.prototype.handleVolumeSliderChange): Deleted.
     18
    1192016-04-27  Youenn Fablet  <youenn.fablet@crf.canon.fr>
    220
  • trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js

    r195809 r200126  
    391391        volume.max = 1;
    392392        volume.step = .01;
    393         this.listenFor(volume, 'change', this.handleVolumeSliderChange);
     393        this.listenFor(volume, 'input', this.handleVolumeSliderInput);
    394394
    395395        var captionButton = this.controls.captionButton = document.createElement('button');
     
    821821    },
    822822
    823     handleVolumeSliderChange: function(event)
     823    handleVolumeSliderInput: function(event)
    824824    {
    825825        if (this.video.muted) {
Note: See TracChangeset for help on using the changeset viewer.