Changeset 200240 in webkit
- Timestamp:
- Apr 29, 2016 6:08:03 AM (8 years ago)
- Location:
- trunk
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r200234 r200240 1 2016-04-29 Joanmarie Diggs <jdiggs@igalia.com> 2 3 AX: [ATK] Expose elements with ARIA's "text" role 4 https://bugs.webkit.org/show_bug.cgi?id=157160 5 6 Reviewed by Chris Fleizach. 7 8 * accessibility/aria-text-role.html: Modified to do platform-specific role checks. 9 * platform/gtk/TestExpectations: Unskipped three previously-failing tests. 10 * platform/gtk/accessibility/roles-computedRoleString-expected.txt: Updated for new behavior. 11 1 12 2016-04-29 Ryosuke Niwa <rniwa@webkit.org> 2 13 -
trunk/LayoutTests/accessibility/aria-text-role.html
r155274 r200240 23 23 document.getElementById("textrole").focus(); 24 24 var textrole = accessibilityController.focusedElement; 25 shouldBe("textrole.role", "'AXRole: AXStaticText'"); 25 if (accessibilityController.platformName == "atk") 26 shouldBe("textrole.role", "'AXRole: AXStatic'"); 27 else 28 shouldBe("textrole.role", "'AXRole: AXStaticText'"); 26 29 shouldBe("textrole.stringValue", "'AXValue: all at once'"); 27 30 -
trunk/LayoutTests/platform/gtk/TestExpectations
r200126 r200240 1842 1842 1843 1843 webkit.org/b/98357 accessibility/aria-readonly.html [ Failure ] 1844 webkit.org/b/98359 accessibility/aria-text-role.html [ Failure ]1845 1844 webkit.org/b/98363 accessibility/canvas-fallback-content-2.html [ Failure ] 1846 1845 webkit.org/b/98372 accessibility/onclick-handlers.html [ Failure ] … … 1848 1847 webkit.org/b/98380 accessibility/th-as-title-ui.html [ Failure ] 1849 1848 webkit.org/b/98382 accessibility/visible-elements.html [ Failure ] 1850 1851 webkit.org/b/125506 accessibility/alt-tag-on-image-with-nonimage-role.html [ Failure ]1852 1849 1853 1850 # Blur and focus events are not received for the following tests. … … 2093 2090 2094 2091 webkit.org/b/116806 fast/css/text-overflow-ellipsis-behind-floats.html [ ImageOnlyFailure ] 2095 2096 webkit.org/b/117581 accessibility/text-role-with-aria-hidden-inside.html [ Failure ]2097 2092 2098 2093 webkit.org/b/117582 fast/flexbox/clear-overflow-before-scroll-update.html [ Failure ] -
trunk/LayoutTests/platform/gtk/accessibility/roles-computedRoleString-expected.txt
r200222 r200240 175 175 PASS: img[role="foo 176 176 bar"] -> img. 177 PASS: img[role="text"] -> text. 178 PASS: img[role="text img"] -> text. 177 179 PASS: img[role="img text"] -> img. 178 180 PASS: img[role="presentation"][aria-label] -> img. -
trunk/Source/WebCore/ChangeLog
r200237 r200240 1 2016-04-29 Joanmarie Diggs <jdiggs@igalia.com> 2 3 AX: [ATK] Expose elements with ARIA's "text" role 4 https://bugs.webkit.org/show_bug.cgi?id=157160 5 6 Reviewed by Chris Fleizach. 7 8 WebCore Accessibility's StaticTextRole is used for exposed RenderText 9 objects and for the ARIA "text" role. The former should be folded into 10 the parent element; the latter should not be, but was. Now we check to 11 see which type we have when building the accessibility tree. Also map 12 the "text" role to ATK_ROLE_STATIC. 13 14 We already have sufficient test coverage. Three previously-failing tests 15 are now passing. 16 17 * accessibility/atk/AccessibilityObjectAtk.cpp: 18 (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): 19 * accessibility/atk/WebKitAccessibleWrapperAtk.cpp: 20 (atkRole): 21 1 22 2016-04-29 Carlos Garcia Campos <cgarcia@igalia.com> 2 23 -
trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp
r200188 r200240 65 65 66 66 // The object containing the text should implement AtkText itself. 67 // However, WebCore also maps ARIA's "text" role to the StaticTextRole. 67 68 if (role == StaticTextRole) 68 return IgnoreObject;69 return ariaRoleAttribute() != UnknownRole ? DefaultBehavior : IgnoreObject; 69 70 70 71 // Include all list items, regardless they have or not inline children -
trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
r200222 r200240 533 533 return ATK_ROLE_ENTRY; 534 534 case StaticTextRole: 535 #if ATK_CHECK_VERSION(2, 15, 2) 536 return ATK_ROLE_STATIC; 537 #else 535 538 return ATK_ROLE_TEXT; 539 #endif 536 540 case OutlineRole: 537 541 case TreeRole:
Note: See TracChangeset
for help on using the changeset viewer.