Changeset 200352 in webkit


Ignore:
Timestamp:
May 2, 2016 6:01:53 PM (8 years ago)
Author:
beidson@apple.com
Message:

Const-ify some IDB code.
https://bugs.webkit.org/show_bug.cgi?id=157287

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Refactor only).

  • Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
  • Modules/indexeddb/shared/InProcessIDBServer.cpp:

(WebCore::InProcessIDBServer::deleteDatabase):
(WebCore::InProcessIDBServer::openDatabase):
(WebCore::InProcessIDBServer::abortTransaction):
(WebCore::InProcessIDBServer::commitTransaction):
(WebCore::InProcessIDBServer::didFinishHandlingVersionChangeTransaction):

  • Modules/indexeddb/shared/InProcessIDBServer.h:

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::deleteDatabase):
(WebKit::WebIDBConnectionToServer::openDatabase):
(WebKit::WebIDBConnectionToServer::abortTransaction):
(WebKit::WebIDBConnectionToServer::commitTransaction):
(WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):

  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r200347 r200352  
     12016-05-02  Brady Eidson  <beidson@apple.com>
     2
     3        Const-ify some IDB code.
     4        https://bugs.webkit.org/show_bug.cgi?id=157287
     5
     6        Reviewed by Alex Christensen.
     7
     8        No new tests (Refactor only).
     9
     10        * Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
     11        * Modules/indexeddb/shared/InProcessIDBServer.cpp:
     12        (WebCore::InProcessIDBServer::deleteDatabase):
     13        (WebCore::InProcessIDBServer::openDatabase):
     14        (WebCore::InProcessIDBServer::abortTransaction):
     15        (WebCore::InProcessIDBServer::commitTransaction):
     16        (WebCore::InProcessIDBServer::didFinishHandlingVersionChangeTransaction):
     17        * Modules/indexeddb/shared/InProcessIDBServer.h:
     18
    1192016-05-02  Antti Koivisto  <antti@apple.com>
    220
  • trunk/Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h

    r200163 r200352  
    5858
    5959    virtual uint64_t identifier() const = 0;
    60     virtual void deleteDatabase(IDBRequestData&) = 0;
    61     virtual void openDatabase(IDBRequestData&) = 0;
    62     virtual void abortTransaction(IDBResourceIdentifier&) = 0;
    63     virtual void commitTransaction(IDBResourceIdentifier&) = 0;
    64     virtual void didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier&) = 0;
     60    virtual void deleteDatabase(const IDBRequestData&) = 0;
     61    virtual void openDatabase(const IDBRequestData&) = 0;
     62    virtual void abortTransaction(const IDBResourceIdentifier&) = 0;
     63    virtual void commitTransaction(const IDBResourceIdentifier&) = 0;
     64    virtual void didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier&) = 0;
    6565    virtual void createObjectStore(const IDBRequestData&, const IDBObjectStoreInfo&) = 0;
    6666    virtual void deleteObjectStore(const IDBRequestData&, const String& objectStoreName) = 0;
  • trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp

    r200163 r200352  
    9090}
    9191
    92 void InProcessIDBServer::deleteDatabase(IDBRequestData& requestData)
     92void InProcessIDBServer::deleteDatabase(const IDBRequestData& requestData)
    9393{
    9494    RefPtr<InProcessIDBServer> self(this);
     
    106106}
    107107
    108 void InProcessIDBServer::openDatabase(IDBRequestData& requestData)
     108void InProcessIDBServer::openDatabase(const IDBRequestData& requestData)
    109109{
    110110    RefPtr<InProcessIDBServer> self(this);
     
    226226}
    227227
    228 void InProcessIDBServer::abortTransaction(IDBResourceIdentifier& resourceIdentifier)
     228void InProcessIDBServer::abortTransaction(const IDBResourceIdentifier& resourceIdentifier)
    229229{
    230230    RefPtr<InProcessIDBServer> self(this);
     
    234234}
    235235
    236 void InProcessIDBServer::commitTransaction(IDBResourceIdentifier& resourceIdentifier)
     236void InProcessIDBServer::commitTransaction(const IDBResourceIdentifier& resourceIdentifier)
    237237{
    238238    RefPtr<InProcessIDBServer> self(this);
     
    242242}
    243243
    244 void InProcessIDBServer::didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier& transactionIdentifier)
     244void InProcessIDBServer::didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier& transactionIdentifier)
    245245{
    246246    RefPtr<InProcessIDBServer> self(this);
  • trunk/Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h

    r200163 r200352  
    5656
    5757    // IDBConnectionToServer
    58     void deleteDatabase(IDBRequestData&) final;
    59     void openDatabase(IDBRequestData&) final;
    60     void abortTransaction(IDBResourceIdentifier&) final;
    61     void commitTransaction(IDBResourceIdentifier&) final;
    62     void didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier&) final;
     58    void deleteDatabase(const IDBRequestData&) final;
     59    void openDatabase(const IDBRequestData&) final;
     60    void abortTransaction(const IDBResourceIdentifier&) final;
     61    void commitTransaction(const IDBResourceIdentifier&) final;
     62    void didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier&) final;
    6363    void createObjectStore(const IDBRequestData&, const IDBObjectStoreInfo&) final;
    6464    void deleteObjectStore(const IDBRequestData&, const String& objectStoreName) final;
  • trunk/Source/WebKit2/ChangeLog

    r200344 r200352  
     12016-05-02  Brady Eidson  <beidson@apple.com>
     2
     3        Const-ify some IDB code.
     4        https://bugs.webkit.org/show_bug.cgi?id=157287
     5
     6        Reviewed by Alex Christensen.
     7
     8        * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
     9        (WebKit::WebIDBConnectionToServer::deleteDatabase):
     10        (WebKit::WebIDBConnectionToServer::openDatabase):
     11        (WebKit::WebIDBConnectionToServer::abortTransaction):
     12        (WebKit::WebIDBConnectionToServer::commitTransaction):
     13        (WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
     14        * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
     15
    1162016-05-02  Simon Fraser  <simon.fraser@apple.com>
    217
  • trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp

    r200163 r200352  
    8282}
    8383
    84 void WebIDBConnectionToServer::deleteDatabase(IDBRequestData& requestData)
     84void WebIDBConnectionToServer::deleteDatabase(const IDBRequestData& requestData)
    8585{
    8686    send(Messages::WebIDBConnectionToClient::DeleteDatabase(requestData));
    8787}
    8888
    89 void WebIDBConnectionToServer::openDatabase(IDBRequestData& requestData)
     89void WebIDBConnectionToServer::openDatabase(const IDBRequestData& requestData)
    9090{
    9191    send(Messages::WebIDBConnectionToClient::OpenDatabase(requestData));
    9292}
    9393
    94 void WebIDBConnectionToServer::abortTransaction(IDBResourceIdentifier& transactionIdentifier)
     94void WebIDBConnectionToServer::abortTransaction(const IDBResourceIdentifier& transactionIdentifier)
    9595{
    9696    send(Messages::WebIDBConnectionToClient::AbortTransaction(transactionIdentifier));
    9797}
    9898
    99 void WebIDBConnectionToServer::commitTransaction(IDBResourceIdentifier& transactionIdentifier)
     99void WebIDBConnectionToServer::commitTransaction(const IDBResourceIdentifier& transactionIdentifier)
    100100{
    101101    send(Messages::WebIDBConnectionToClient::CommitTransaction(transactionIdentifier));
    102102}
    103103
    104 void WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier& transactionIdentifier)
     104void WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier& transactionIdentifier)
    105105{
    106106    send(Messages::WebIDBConnectionToClient::DidFinishHandlingVersionChangeTransaction(transactionIdentifier));
  • trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h

    r200163 r200352  
    4646
    4747    // IDBConnectionToServerDelegate
    48     void deleteDatabase(WebCore::IDBRequestData&) final;
    49     void openDatabase(WebCore::IDBRequestData&) final;
    50     void abortTransaction(WebCore::IDBResourceIdentifier&) final;
    51     void commitTransaction(WebCore::IDBResourceIdentifier&) final;
    52     void didFinishHandlingVersionChangeTransaction(WebCore::IDBResourceIdentifier&) final;
     48    void deleteDatabase(const WebCore::IDBRequestData&) final;
     49    void openDatabase(const WebCore::IDBRequestData&) final;
     50    void abortTransaction(const WebCore::IDBResourceIdentifier&) final;
     51    void commitTransaction(const WebCore::IDBResourceIdentifier&) final;
     52    void didFinishHandlingVersionChangeTransaction(const WebCore::IDBResourceIdentifier&) final;
    5353    void createObjectStore(const WebCore::IDBRequestData&, const WebCore::IDBObjectStoreInfo&) final;
    5454    void deleteObjectStore(const WebCore::IDBRequestData&, const String& objectStoreName) final;
Note: See TracChangeset for help on using the changeset viewer.