Changeset 200366 in webkit

Timestamp:

May 3, 2016 2:09:25 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

Unreviewed GTK+ gardening. Update drag and drop tests bug reference.

We were using a fixed bug, because drag and drop was already implemented in WebKit2. However, some tests still
fail because some drag and drop events are not emitted when using synthetic events like even sender does. So,
update the bug reference to ​https://bugs.webkit.org/show_bug.cgi?id=157179 and add two more tests that are
timing out in the bots for the same reason.

• platform/gtk/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Unreviewed GTK+ gardening. Update drag and drop tests bug reference.
+
+        We were using a fixed bug, because drag and drop was already implemented in WebKit2. However, some tests still
+        fail because some drag and drop events are not emitted when using synthetic events like even sender does. So,
+        update the bug reference to https://bugs.webkit.org/show_bug.cgi?id=157179 and add two more tests that are
+        timing out in the bots for the same reason.
+
+        * platform/gtk/TestExpectations:
+
 2016-05-02  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -1641 +1641 @@
 #////////////////////////////////////////////////////////////////////////////////////////
 #
-# [GTK] Implement drag and drop support in WebKit2
-# https://bugs.webkit.org/show_bug.cgi?id=63706
+# [GTK] Drag and drop can't be tested with WebKitTestRunner
+# https://bugs.webkit.org/show_bug.cgi?id=157179
 # Implement EditingCallbacks deletegates in the WebKitTestRunner
-webkit.org/b/63706 editing/pasteboard/4947130.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/dataTransfer-setData-getData.html [ Failure Timeout ]
-webkit.org/b/63706 editing/pasteboard/drag-and-drop-image-contenteditable.html [ Failure Timeout ]
-webkit.org/b/63706 editing/pasteboard/drag-and-drop-inputimage-contenteditable.html [ Failure Timeout ]
-webkit.org/b/63706 editing/pasteboard/drag-and-drop-objectimage-contenteditable.html [ Failure Timeout ]
-webkit.org/b/63706 editing/pasteboard/drag-drop-input-textarea.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/drag-drop-modifies-page.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/drag-drop-url-text.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/drag-image-in-about-blank-frame.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/drag-selected-image-to-contenteditable.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/drop-file-svg.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/drop-inputtext-acquires-style.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/drop-link.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/drop-text-without-selection.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/get-data-text-plain-drop.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/smart-drag-drop.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/subframe-dragndrop-1.html [ Failure ]
-webkit.org/b/63706 editing/selection/4895428-1.html [ Failure ]
-webkit.org/b/63706 editing/selection/4895428-4.html [ Failure ]
-webkit.org/b/63706 editing/selection/contains-boundaries.html [ Failure ]
-webkit.org/b/63706 editing/selection/drag-text-delay.html [ Failure ]
-webkit.org/b/63706 fast/block/float/float-in-float-hit-testing.html [ Failure ]
-webkit.org/b/63706 fast/events/bogus-dropEffect-effectAllowed.html [ Failure ]
-webkit.org/b/63706 fast/events/content-changed-during-drop.html [ Failure ]
-webkit.org/b/63706 fast/events/crash-on-mutate-during-drop.html [ Failure ]
-webkit.org/b/63706 fast/events/drag-and-drop-dataTransfer-types-nocrash.html [ Failure ]
-webkit.org/b/63706 fast/events/drag-and-drop-fire-drag-dragover.html [ Failure ]
-webkit.org/b/63706 fast/events/drag-and-drop.html [ Failure Timeout ]
-webkit.org/b/63706 fast/events/drag-and-drop-subframe-dataTransfer.html [ Failure Timeout ]
+webkit.org/b/157179 editing/pasteboard/4947130.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/dataTransfer-setData-getData.html [ Failure Timeout ]
+webkit.org/b/157179 editing/pasteboard/drag-and-drop-image-contenteditable.html [ Failure Timeout ]
+webkit.org/b/157179 editing/pasteboard/drag-and-drop-inputimage-contenteditable.html [ Failure Timeout ]
+webkit.org/b/157179 editing/pasteboard/drag-and-drop-objectimage-contenteditable.html [ Failure Timeout ]
+webkit.org/b/157179 editing/pasteboard/drag-drop-input-textarea.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/drag-drop-modifies-page.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/drag-drop-url-text.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/drag-image-in-about-blank-frame.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/drag-selected-image-to-contenteditable.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/drop-file-svg.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/drop-inputtext-acquires-style.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/drop-link.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/drop-text-without-selection.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/get-data-text-plain-drop.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/smart-drag-drop.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/subframe-dragndrop-1.html [ Failure ]
+webkit.org/b/157179 editing/selection/4895428-1.html [ Failure ]
+webkit.org/b/157179 editing/selection/4895428-4.html [ Failure ]
+webkit.org/b/157179 editing/selection/contains-boundaries.html [ Failure ]
+webkit.org/b/157179 editing/selection/drag-text-delay.html [ Failure ]
+webkit.org/b/157179 fast/block/float/float-in-float-hit-testing.html [ Failure ]
+webkit.org/b/157179 fast/events/bogus-dropEffect-effectAllowed.html [ Failure ]
+webkit.org/b/157179 fast/events/content-changed-during-drop.html [ Failure ]
+webkit.org/b/157179 fast/events/crash-on-mutate-during-drop.html [ Failure ]
+webkit.org/b/157179 fast/events/drag-and-drop-dataTransfer-types-nocrash.html [ Failure ]
+webkit.org/b/157179 fast/events/drag-and-drop-fire-drag-dragover.html [ Failure ]
+webkit.org/b/157179 fast/events/drag-and-drop.html [ Failure Timeout ]
+webkit.org/b/157179 fast/events/drag-and-drop-subframe-dataTransfer.html [ Failure Timeout ]
 webkit.org/b/42194 fast/events/drag-and-drop-link.html [ Failure ]
-webkit.org/b/63706 fast/events/drag-and-drop-link-into-focused-contenteditable.html [ Failure ]
-webkit.org/b/63706 fast/events/drag-parent-node.html [ Failure ]
-webkit.org/b/63706 fast/events/dropzone-001.html [ Failure Timeout ]
-webkit.org/b/63706 fast/events/dropzone-002.html [ Failure Timeout ]
-webkit.org/b/63706 fast/events/dropzone-003.html [ Failure Timeout ]
-webkit.org/b/63706 fast/events/ondrop-text-html.html [ Failure ]
-webkit.org/b/63706 fast/events/selectstart-by-drag.html [ Failure ]
-webkit.org/b/63706 fast/events/standalone-image-drag-to-editable.html [ Failure Timeout ]
-webkit.org/b/63706 fast/forms/drag-into-textarea.html [ Failure ]
-webkit.org/b/63706 fast/forms/drag-out-of-textarea.html [ Failure ]
-webkit.org/b/63706 fast/forms/range/slider-delete-while-dragging-thumb.html [ Failure ]
-webkit.org/b/63706 fast/lists/drag-into-marker.html [ Failure ]
-webkit.org/b/63706 http/tests/security/resources/drag-drop-allowed.html [ Skip ]
-webkit.org/b/63706 plugins/mouse-events-fixedpos.html [ Failure ]
-webkit.org/b/63706 plugins/mouse-events.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/cleanup-on-move.html [ Failure ]
-webkit.org/b/63706 editing/pasteboard/drag-list-item.html [ Failure ]
-webkit.org/b/63706 fast/events/ondragenter.html [ Failure ]
-webkit.org/b/63706 fast/events/drag-customData.html  [ Timeout ]
+webkit.org/b/157179 fast/events/drag-and-drop-link-into-focused-contenteditable.html [ Failure ]
+webkit.org/b/157179 fast/events/drag-parent-node.html [ Failure ]
+webkit.org/b/157179 fast/events/dropzone-001.html [ Failure Timeout ]
+webkit.org/b/157179 fast/events/dropzone-002.html [ Failure Timeout ]
+webkit.org/b/157179 fast/events/dropzone-003.html [ Failure Timeout ]
+webkit.org/b/157179 fast/events/ondrop-text-html.html [ Failure ]
+webkit.org/b/157179 fast/events/selectstart-by-drag.html [ Failure ]
+webkit.org/b/157179 fast/events/standalone-image-drag-to-editable.html [ Failure Timeout ]
+webkit.org/b/157179 fast/forms/drag-into-textarea.html [ Failure ]
+webkit.org/b/157179 fast/forms/drag-out-of-textarea.html [ Failure ]
+webkit.org/b/157179 fast/forms/range/slider-delete-while-dragging-thumb.html [ Failure ]
+webkit.org/b/157179 fast/lists/drag-into-marker.html [ Failure ]
+webkit.org/b/157179 http/tests/security/resources/drag-drop-allowed.html [ Skip ]
+webkit.org/b/157179 plugins/mouse-events-fixedpos.html [ Failure ]
+webkit.org/b/157179 plugins/mouse-events.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/cleanup-on-move.html [ Failure ]
+webkit.org/b/157179 editing/pasteboard/drag-list-item.html [ Failure ]
+webkit.org/b/157179 fast/events/ondragenter.html [ Failure ]
+webkit.org/b/157179 fast/events/drag-customData.html  [ Timeout ]
+webkit.org/b/157179 fast/events/drag-and-drop-autoscroll-inner-frame.html [ Timeout ]
+webkit.org/b/157179 fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html [ Timeout ]
 
 # Need support for internals.settings.setDeviceSupportsMouse