Changeset 200509 in webkit

Timestamp:

May 6, 2016 12:45:04 AM (8 years ago)

Author:

n_wang@apple.com

Message:

AX: <attachment> element should have a replacement character
​https://bugs.webkit.org/show_bug.cgi?id=157406

Reviewed by Chris Fleizach.

Source/WebCore:

Make sure attachment element is considered as a replaced node.

Test: accessibility/mac/attachment-element-replacement-character.html

• editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

LayoutTests:

• accessibility/attachment-element-expected.txt:
• accessibility/mac/attachment-element-replacement-character-expected.txt: Added.
• accessibility/mac/attachment-element-replacement-character.html: Added.
• editing/pasteboard/drag-and-drop-attachment-contenteditable-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/attachment-element-expected.txt (modified) (1 diff)
• LayoutTests/accessibility/mac/attachment-element-replacement-character-expected.txt (added)
• LayoutTests/accessibility/mac/attachment-element-replacement-character.html (added)
• LayoutTests/editing/pasteboard/drag-and-drop-attachment-contenteditable-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/editing/TextIterator.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-05-06  Nan Wang  <n_wang@apple.com>
+
+        AX: <attachment> element should have a replacement character
+        https://bugs.webkit.org/show_bug.cgi?id=157406
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/attachment-element-expected.txt:
+        * accessibility/mac/attachment-element-replacement-character-expected.txt: Added.
+        * accessibility/mac/attachment-element-replacement-character.html: Added.
+        * editing/pasteboard/drag-and-drop-attachment-contenteditable-expected.txt:
+
 2016-05-06  Nan Wang  <n_wang@apple.com>
 

trunk/LayoutTests/accessibility/attachment-element-expected.txt

@@ +1 @@
+
 This tests that attachment elements are accessible.
 

trunk/LayoutTests/editing/pasteboard/drag-and-drop-attachment-contenteditable-expected.txt

@@ -2 +2 @@
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
 
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-05-06  Nan Wang  <n_wang@apple.com>
+
+        AX: <attachment> element should have a replacement character
+        https://bugs.webkit.org/show_bug.cgi?id=157406
+
+        Reviewed by Chris Fleizach.
+
+        Make sure attachment element is considered as a replaced node.
+
+        Test: accessibility/mac/attachment-element-replacement-character.html
+
+        * editing/TextIterator.cpp:
+        (WebCore::isRendererReplacedElement):
+
 2016-05-06  Nan Wang  <n_wang@apple.com>
 

trunk/Source/WebCore/editing/TextIterator.cpp

@@ -255 +255 @@
         return false;
     
-    if (renderer->isImage() || renderer->isWidget() || renderer->isMedia())
+    bool isAttachment = false;
+#if ENABLE(ATTACHMENT_ELEMENT)
+    isAttachment = renderer->isAttachment();
+#endif
+    if (renderer->isImage() || renderer->isWidget() || renderer->isMedia() || isAttachment)
         return true;