Changeset 201079 in webkit

Timestamp:

May 18, 2016 7:52:20 AM (8 years ago)

Author:

BJ Burg

Message:

REGRESSION(r200959): "Start Timeline Recording" menu item doesn't start recording
​https://bugs.webkit.org/show_bug.cgi?id=157821
<rdar://problem/26335429>

Reviewed by Timothy Hatcher.

In r200959, WebInspectorProxy started sending start/stop profiling
messages directly to the frontend process to avoid the inspected page
process from implicitly showing the frontend. To compensate, the WebKit
API layer was changed to call show() in togglePageProfiling().

Unfortunately, this fix was not quite right, because the ordering of
the Show and StartPageProfiling messages is undefined. The latter has to bounce
from UI to inspected to inspector processes, so the frontend may try
to start profiling before the frontend is shown, causing it to be ignored.

This patch takes a different approach: just remove all implicit show()
calls in the inspected page processes, and bounce both the Show and
StartPageProfiling messages through the inspected page process to ensure
they are handled in order by the frontend process.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::togglePageProfiling):
Revert to sending to the inspected page process.

• WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:

(WKBundleInspectorSetPageProfilingEnabled):
Add a call to show() now that the implementation doesn't do it implicitly.

• WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
Don't implicitly show the inspector. These methods are only called
through the WKBundleInspector API and via IPC from WebInspectorProxy.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebInspectorProxy.cpp (modified) (1 diff)
• WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp (modified) (1 diff)
• WebProcess/WebPage/WebInspector.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-05-18  Brian Burg  <bburg@apple.com>
+
+        REGRESSION(r200959): "Start Timeline Recording" menu item doesn't start recording
+        https://bugs.webkit.org/show_bug.cgi?id=157821
+        <rdar://problem/26335429>
+
+        Reviewed by Timothy Hatcher.
+
+        In r200959, WebInspectorProxy started sending start/stop profiling
+        messages directly to the frontend process to avoid the inspected page
+        process from implicitly showing the frontend. To compensate, the WebKit
+        API layer was changed to call show() in togglePageProfiling().
+
+        Unfortunately, this fix was not quite right, because the ordering of
+        the Show and StartPageProfiling messages is undefined. The latter has to bounce
+        from UI to inspected to inspector processes, so the frontend may try
+        to start profiling before the frontend is shown, causing it to be ignored.
+
+        This patch takes a different approach: just remove all implicit show()
+        calls in the inspected page processes, and bounce both the Show and
+        StartPageProfiling messages through the inspected page process to ensure
+        they are handled in order by the frontend process.
+
+        * UIProcess/WebInspectorProxy.cpp:
+        (WebKit::WebInspectorProxy::togglePageProfiling):
+        Revert to sending to the inspected page process.
+
+        * WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
+        (WKBundleInspectorSetPageProfilingEnabled):
+        Add a call to show() now that the implementation doesn't do it implicitly.
+
+        * WebProcess/WebPage/WebInspector.cpp:
+        (WebKit::WebInspector::startPageProfiling):
+        (WebKit::WebInspector::stopPageProfiling):
+        Don't implicitly show the inspector. These methods are only called
+        through the WKBundleInspector API and via IPC from WebInspectorProxy.
+
 2016-05-17  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp

@@ -297 +297 @@
 
     if (m_isProfilingPage)
-        m_inspectorPage->process().send(Messages::WebInspectorUI::StopPageProfiling(), m_inspectorPage->pageID());
+        m_inspectedPage->process().send(Messages::WebInspector::StopPageProfiling(), m_inspectedPage->pageID());
     else
-        m_inspectorPage->process().send(Messages::WebInspectorUI::StartPageProfiling(), m_inspectorPage->pageID());
+        m_inspectedPage->process().send(Messages::WebInspector::StartPageProfiling(), m_inspectedPage->pageID());
 
     // FIXME: have the WebProcess notify us on state changes.

trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp

@@ -56 +56 @@
 void WKBundleInspectorSetPageProfilingEnabled(WKBundleInspectorRef inspectorRef, bool enabled)
 {
+    toImpl(inspectorRef)->show();
+
     if (enabled)
         toImpl(inspectorRef)->startPageProfiling();

trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp

@@ -197 +197 @@
         return;
 
-    m_page->corePage()->inspectorController().show();
     m_frontendConnection->send(Messages::WebInspectorUI::StartPageProfiling(), 0);
 }
@@ -206 +205 @@
         return;
 
-    m_page->corePage()->inspectorController().show();
     m_frontendConnection->send(Messages::WebInspectorUI::StopPageProfiling(), 0);
 }