Changeset 201130 in webkit

Timestamp:

May 19, 2016 1:08:30 AM (8 years ago)

Author:

yoav@yoav.ws

Message:

REGRESSION (r200887): LayoutTest http/tests/performance/performance-resource-timing-cached-entries.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=157816

Reviewed by Alexey Proskuryakov.

Mark the test as flaky, and add console logs to try to figure out the cause for flakiness.

• TestExpectations: Mark the test as flaky.
• http/tests/performance/performance-resource-timing-cached-entries.html: Add prints to better identify the flakiness root cause.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (3 diffs)
• TestExpectations (modified) (1 diff)
• http/tests/performance/performance-resource-timing-cached-entries-expected.txt (modified) (1 diff)
• http/tests/performance/performance-resource-timing-cached-entries.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-05-19  Yoav Weiss  <yoav@yoav.ws>
+
+        REGRESSION (r200887): LayoutTest http/tests/performance/performance-resource-timing-cached-entries.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=157816
+
+        Reviewed by Alexey Proskuryakov.
+
+        Mark the test as flaky, and add console logs to try to figure out the cause for flakiness.
+
+        * TestExpectations: Mark the test as flaky.
+        * http/tests/performance/performance-resource-timing-cached-entries.html: Add prints to better identify the flakiness root cause.
+
 2016-05-18  Jer Noble  <jer.noble@apple.com>
 
@@ -2678 +2690 @@
 
         Remove failure expectation for passing tests, move some to more specific ports, and remove expectations
-                for tests that are no longer in the tree.
+        for tests that are no longer in the tree.
 
         * platform/ios-simulator-wk1/TestExpectations:
@@ -4216 +4228 @@
         Unreviewed test gardening.
 
-                I evaluated all of the unexpected passes from ios-simulator-wk2 and removed failure
-                expectations where appropriate. Some of the tests only pass on wk2, so some expectations
-                were moved to the ios-simulator-wk1 file.
+        I evaluated all of the unexpected passes from ios-simulator-wk2 and removed failure
+        expectations where appropriate. Some of the tests only pass on wk2, so some expectations
+        were moved to the ios-simulator-wk1 file.
 
         * platform/ios-simulator-wk1/TestExpectations:

trunk/LayoutTests/TestExpectations

@@ -979 +979 @@
 
 webkit.org/b/157589 fast/text-autosizing/ios/text-autosizing-after-back.html [ Pass Timeout ]
+
+webkit.org/b/157816 http/tests/performance/performance-resource-timing-cached-entries.html [ Pass Failure ]
+

trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries-expected.txt

@@ +1 @@
+CONSOLE MESSAGE: line 11: current entries: 0
+CONSOLE MESSAGE: line 20: entry: http://127.0.0.1:8000/resources/js-test-pre.js
+CONSOLE MESSAGE: line 20: entry: http://127.0.0.1:8000/resources/square100.png
+CONSOLE MESSAGE: line 20: entry: http://127.0.0.1:8000/resources/square100.png
 PASS foundResource is 2
 

trunk/LayoutTests/http/tests/performance/performance-resource-timing-cached-entries.html

@@ -8 +8 @@
         testRunner.waitUntilDone();
     }
+    if (window.performance)
+        console.log("current entries: " + performance.getEntriesByType('resource').length);
 </script>
 <script src="../../resources/js-test-pre.js"></script>
@@ -16 +18 @@
         var resources = performance.getEntriesByType('resource');
         for (var i = 0; i < resources.length; ++i) {
+            console.log("entry: " + resources[i].name);
             if (resources[i].name.indexOf("square") != -1)
                 ++foundResource;