Changeset 201177 in webkit


Ignore:
Timestamp:
May 19, 2016 1:22:19 PM (8 years ago)
Author:
timothy@apple.com
Message:

Web Inspector: Timelines "Edit" button should be right-aligned
https://bugs.webkit.org/show_bug.cgi?id=157909
rdar://problem/26373969

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/ButtonNavigationItem.css:

(.navigation-bar .item.button.text-only): Deleted height: auto. Now inherited.

  • UserInterface/Views/NavigationBar.css:

(.navigation-bar .item): Change height to auto to support any NavigationBar height.
This is needed since the Timelines tab has a shorter NavigationBar height, and
flexible items were overflowing.

  • UserInterface/Views/TextNavigationItem.css:

(.navigation-bar .item.text): Deleted height: auto. Now inherited.

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview): Add a FlexibleSpaceNavigationItem before the Edit button.

Location:
trunk/Source/WebInspectorUI
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r201171 r201177  
     12016-05-19  Timothy Hatcher  <timothy@apple.com>
     2
     3        Web Inspector: Timelines "Edit" button should be right-aligned
     4        https://bugs.webkit.org/show_bug.cgi?id=157909
     5        rdar://problem/26373969
     6
     7        Reviewed by Joseph Pecoraro.
     8
     9        * UserInterface/Views/ButtonNavigationItem.css:
     10        (.navigation-bar .item.button.text-only): Deleted height: auto. Now inherited.
     11        * UserInterface/Views/NavigationBar.css:
     12        (.navigation-bar .item): Change height to auto to support any NavigationBar height.
     13        This is needed since the Timelines tab has a shorter NavigationBar height, and
     14        flexible items were overflowing.
     15        * UserInterface/Views/TextNavigationItem.css:
     16        (.navigation-bar .item.text): Deleted height: auto. Now inherited.
     17        * UserInterface/Views/TimelineOverview.js:
     18        (WebInspector.TimelineOverview): Add a FlexibleSpaceNavigationItem before the Edit button.
     19
    1202016-05-19  Brian Burg  <bburg@apple.com>
    221
  • trunk/Source/WebInspectorUI/UserInterface/Views/ButtonNavigationItem.css

    r197029 r201177  
    3939    border-radius: 3px;
    4040    text-align: center;
    41     height: auto;
    4241}
    4342
  • trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.css

    r200529 r201177  
    4444    flex-wrap: wrap;
    4545
    46     height: 28px;
     46    height: auto;
    4747    outline: none;
    4848}
  • trunk/Source/WebInspectorUI/UserInterface/Views/TextNavigationItem.css

    r197954 r201177  
    3232    color: hsl(0, 0%, 18%);
    3333    text-align: center;
    34     height: auto;
    3534}
  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js

    r200805 r201177  
    6565        let instrumentsNavigationBar = new WebInspector.NavigationBar;
    6666        instrumentsNavigationBar.element.classList.add("timelines");
     67        instrumentsNavigationBar.addNavigationItem(new WebInspector.FlexibleSpaceNavigationItem);
    6768        instrumentsNavigationBar.addNavigationItem(this._editInstrumentsButton);
    6869        this.addSubview(instrumentsNavigationBar);
Note: See TracChangeset for help on using the changeset viewer.