Changeset 201288 in webkit

Timestamp:

May 23, 2016 9:46:38 AM (8 years ago)

Author:

beidson@apple.com

Message:

check-webkit-style gets flags std::literals::chrono_literals as bad naming.
​https://bugs.webkit.org/show_bug.cgi?id=157969

Reviewed by Alex Christensen.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_identifier_name_in_declaration):

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_names):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp.py (modified) (1 diff)
• Scripts/webkitpy/style/checkers/cpp_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-05-23  Brady Eidson  <beidson@apple.com>
+
+        check-webkit-style gets flags std::literals::chrono_literals as bad naming.
+        https://bugs.webkit.org/show_bug.cgi?id=157969
+
+        Reviewed by Alex Christensen.
+
+        * Scripts/webkitpy/style/checkers/cpp.py:
+        (check_identifier_name_in_declaration):
+        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+        (WebKitStyleTest.test_names):
+
 2016-05-22  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py

@@ -3401 +3401 @@
                 and not modified_identifier == "const_iterator"
                 and not modified_identifier == "vm_throw"
-                and not modified_identifier == "DFG_OPERATION"):
+                and not modified_identifier == "DFG_OPERATION"
+                and not modified_identifier.find('chrono_literals') >= 0):
                 error(line_number, 'readability/naming/underscores', 4, identifier + " is incorrectly named. Don't use underscores in your identifier names.")
 

trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

@@ -5173 +5173 @@
         self.assert_lint('typedef VectorType::const_iterator const_iterator;', '')
 
+        # chrono_literals is allowed as well.
+        self.assert_lint('using namespace std::literals::chrono_literals;', '')
+
         # vm_throw is allowed as well.
         self.assert_lint('int vm_throw;', '')