Changeset 201447 in webkit

Timestamp:

May 26, 2016 10:43:52 PM (8 years ago)

Author:

yoav@yoav.ws

Message:

Preload single download tests.
​https://bugs.webkit.org/show_bug.cgi?id=157988

Reviewed by Alex Christensen.

Source/WebCore:

ResourceTiming entries for some subresource weren't registered as resource->response().isHTTP() was false, since
resource->response().url() was empty. I switched the check to use resource->resourceRequest().url() directly instead.

Test: http/tests/preload/single_download_preload_runner.html

• loader/ResourceTimingInformation.cpp:

(WebCore::ResourceTimingInformation::addResourceTiming):

LayoutTests:

Make sure preload is only downloading a single resource, which is properly reused.

• http/tests/preload/resources/single_download_preload.html: Added.
• http/tests/preload/single_download_preload_runner-expected.txt: Added.
• http/tests/preload/single_download_preload_runner.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/preload/resources (added)
• LayoutTests/http/tests/preload/resources/single_download_preload.html (added)
• LayoutTests/http/tests/preload/single_download_preload_runner-expected.txt (added)
• LayoutTests/http/tests/preload/single_download_preload_runner.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/loader/ResourceTimingInformation.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-05-26  Yoav Weiss  <yoav@yoav.ws>
+
+        Preload single download tests.
+        https://bugs.webkit.org/show_bug.cgi?id=157988
+
+        Reviewed by Alex Christensen.
+
+        Make sure preload is only downloading a single resource, which is properly reused.
+
+        * http/tests/preload/resources/single_download_preload.html: Added.
+        * http/tests/preload/single_download_preload_runner-expected.txt: Added.
+        * http/tests/preload/single_download_preload_runner.html: Added.
+
 2016-05-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-05-26  Yoav Weiss  <yoav@yoav.ws>
+
+        Preload single download tests.
+        https://bugs.webkit.org/show_bug.cgi?id=157988
+
+        Reviewed by Alex Christensen.
+
+        ResourceTiming entries for some subresource weren't registered as resource->response().isHTTP() was false, since
+        resource->response().url() was empty. I switched the check to use resource->resourceRequest().url() directly instead.
+
+        Test: http/tests/preload/single_download_preload_runner.html
+
+        * loader/ResourceTimingInformation.cpp:
+        (WebCore::ResourceTimingInformation::addResourceTiming):
+
 2016-05-26  Nan Wang  <n_wang@apple.com>
 

trunk/Source/WebCore/loader/ResourceTimingInformation.cpp

@@ -42 +42 @@
 {
     ASSERT(RuntimeEnabledFeatures::sharedFeatures().resourceTimingEnabled());
-    if (resource && resource->response().isHTTP()
+    if (resource && resource->resourceRequest().url().protocolIsInHTTPFamily()
         && ((!resource->errorOccurred() && !resource->wasCanceled()) || resource->response().httpStatusCode() == 304)) {
         HashMap<CachedResource*, InitiatorInfo>::iterator initiatorIt = m_initiatorMap.find(resource);