Changeset 201716 in webkit

Timestamp:

Jun 6, 2016 11:09:20 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[jsc][mips] Implement absDouble()
​https://bugs.webkit.org/show_bug.cgi?id=158206

Patch by Guillaume Emont <​guijemont@igalia.com> on 2016-06-06
Reviewed by Mark Lam.

Implement absDouble() for MIPS. This is needed because Math.pow() uses
it since r200208.

• assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::absd):

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::absDouble):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/MIPSAssembler.h (modified) (1 diff)
• assembler/MacroAssemblerMIPS.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-06-06  Guillaume Emont  <guijemont@igalia.com>
+
+        [jsc][mips] Implement absDouble()
+        https://bugs.webkit.org/show_bug.cgi?id=158206
+
+        Reviewed by Mark Lam.
+
+        Implement absDouble() for MIPS. This is needed because Math.pow() uses
+        it since r200208.
+
+        * assembler/MIPSAssembler.h:
+        (JSC::MIPSAssembler::absd):
+        * assembler/MacroAssemblerMIPS.h:
+        (JSC::MacroAssemblerMIPS::absDouble):
+
 2016-06-03  Oliver Hunt  <oliver@apple.com>
 

trunk/Source/JavaScriptCore/assembler/MIPSAssembler.h

@@ -548 +548 @@
     }
 
+    void absd(FPRegisterID fd, FPRegisterID fs)
+    {
+        emitInst(0x46200005 | (fd << OP_SH_FD) | (fs << OP_SH_FS));
+    }
+
     void movd(FPRegisterID fd, FPRegisterID fs)
     {

trunk/Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h

@@ -642 +642 @@
         m_assembler.sqrtd(dst, src);
     }
-    
-    void absDouble(FPRegisterID, FPRegisterID)
-    {
-        RELEASE_ASSERT_NOT_REACHED();
+
+    void absDouble(FPRegisterID src, FPRegisterID dst)
+    {
+        m_assembler.absd(dst, src);
     }
 
@@ -1276 +1276 @@
 #endif
     }
-    static bool supportsFloatingPointAbs() { return false; }
+
+    static bool supportsFloatingPointAbs()
+    {
+#if WTF_MIPS_DOUBLE_FLOAT && WTF_MIPS_ISA_AT_LEAST(2)
+        return true;
+#else
+        return false;
+#endif
+    }
+
     static bool supportsFloatingPointRounding() { return false; }