Changeset 201741 in webkit


Ignore:
Timestamp:
Jun 6, 2016 10:54:11 PM (8 years ago)
Author:
akling@apple.com
Message:

REGRESSION(r197595): 2% JSBench regression on iPhone 5.
<​https://webkit.org/b/158459>

Unreviewed rollout.

  • runtime/VM.cpp:

(JSC::VM::deleteAllRegExpCode): Deleted.

  • runtime/VM.h:
Location:
trunk/Source
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r201737 r201741  
     12016-06-06  Andreas Kling  <akling@apple.com>
     2
     3        REGRESSION(r197595): 2% JSBench regression on iPhone 5.
     4        <https://webkit.org/b/158459>
     5
     6        Unreviewed rollout.
     7
     8        * runtime/VM.cpp:
     9        (JSC::VM::deleteAllRegExpCode): Deleted.
     10        * runtime/VM.h:
     11
    1122016-06-06  Michael Saboff  <msaboff@apple.com>
    213

  • trunk/Source/JavaScriptCore/runtime/VM.cpp

    r201732 r201741  
    553553}
    554554
    555 void VM::deleteAllRegExpCode()
    556 {
    557     whenIdle([this]() {
    558         m_regExpCache->deleteAllCode();
    559     });
    560 }
    561 
    562555void VM::deleteAllCode()
    563556{

  • trunk/Source/JavaScriptCore/runtime/VM.h

    r201654 r201741  
    577577    JS_EXPORT_PRIVATE void deleteAllCode();
    578578    JS_EXPORT_PRIVATE void deleteAllLinkedCode();
    579     JS_EXPORT_PRIVATE void deleteAllRegExpCode();
    580579
    581580    WatchpointSet* ensureWatchpointSetForImpureProperty(const Identifier&);

  • trunk/Source/WebCore/bindings/js/GCController.cpp

    r197595 r201741  
    129129}
    130130
    131 void GCController::deleteAllRegExpCode()
    132 {
    133     JSLockHolder lock(JSDOMWindow::commonVM());
    134     JSDOMWindow::commonVM().deleteAllRegExpCode();
    135 }
    136 
    137131} // namespace WebCore

  • trunk/Source/WebCore/bindings/js/GCController.h

    r197595 r201741  
    4848    WEBCORE_EXPORT void deleteAllCode();
    4949    WEBCORE_EXPORT void deleteAllLinkedCode();
    50     WEBCORE_EXPORT void deleteAllRegExpCode();
    5150
    5251private:

  • trunk/Source/WebCore/loader/FrameLoader.cpp

    r201679 r201741  
    17911791        // outweigh the cost of recompiling in the case of a future backwards navigation.
    17921792        GCController::singleton().deleteAllLinkedCode();
    1793 
    1794         // Same thing with RegExp bytecode and JIT code.
    1795         GCController::singleton().deleteAllRegExpCode();
    17961793#endif
    17971794    }
Note: See TracChangeset for help on using the changeset viewer.