Changeset 201794 in webkit


Ignore:
Timestamp:
Jun 7, 2016 11:30:47 PM (8 years ago)
Author:
adam.bergkvist@ericsson.com
Message:

WebRTC: Refactor: Use captures with initializers in MediaEndpointPeerConnection::createOffer()
https://bugs.webkit.org/show_bug.cgi?id=158486

Reviewed by Eric Carlson.

Use initializers for the capture list when scheduling the "create offer task".

No change in behavior.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::createOffer):
(WebCore::WrappedSessionDescriptionPromise::create): Deleted.
(WebCore::WrappedSessionDescriptionPromise::promise): Deleted.
(WebCore::WrappedSessionDescriptionPromise::WrappedSessionDescriptionPromise): Deleted.
Not needed anymore.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r201793 r201794  
     12016-06-07  Adam Bergkvist  <adam.bergkvist@ericsson.com>
     2
     3        WebRTC: Refactor: Use captures with initializers in MediaEndpointPeerConnection::createOffer()
     4        https://bugs.webkit.org/show_bug.cgi?id=158486
     5
     6        Reviewed by Eric Carlson.
     7
     8        Use initializers for the capture list when scheduling the "create offer task".
     9
     10        No change in behavior.
     11
     12        * Modules/mediastream/MediaEndpointPeerConnection.cpp:
     13        (WebCore::MediaEndpointPeerConnection::createOffer):
     14        (WebCore::WrappedSessionDescriptionPromise::create): Deleted.
     15        (WebCore::WrappedSessionDescriptionPromise::promise): Deleted.
     16        (WebCore::WrappedSessionDescriptionPromise::WrappedSessionDescriptionPromise): Deleted.
     17        Not needed anymore.
     18
    1192016-06-07  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
    220
  • trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp

    r201728 r201794  
    5555CreatePeerConnectionBackend PeerConnectionBackend::create = createMediaEndpointPeerConnection;
    5656
    57 class WrappedSessionDescriptionPromise : public RefCounted<WrappedSessionDescriptionPromise> {
    58 public:
    59     static Ref<WrappedSessionDescriptionPromise> create(SessionDescriptionPromise&& promise)
    60     {
    61         return *adoptRef(new WrappedSessionDescriptionPromise(WTFMove(promise)));
    62     }
    63 
    64     SessionDescriptionPromise& promise() { return m_promise; }
    65 
    66 private:
    67     WrappedSessionDescriptionPromise(SessionDescriptionPromise&& promise)
    68         : m_promise(WTFMove(promise))
    69     { }
    70 
    71     SessionDescriptionPromise m_promise;
    72 };
    73 
    7457static String randomString(size_t length)
    7558{
     
    134117void MediaEndpointPeerConnection::createOffer(RTCOfferOptions& options, SessionDescriptionPromise&& promise)
    135118{
    136     const RefPtr<RTCOfferOptions> protectedOptions = &options;
    137     RefPtr<WrappedSessionDescriptionPromise> wrappedPromise = WrappedSessionDescriptionPromise::create(WTFMove(promise));
    138 
    139     runTask([this, protectedOptions, wrappedPromise]() {
    140         createOfferTask(*protectedOptions, wrappedPromise->promise());
     119    runTask([this, protectedOptions = RefPtr<RTCOfferOptions>(&options), protectedPromise = WTFMove(promise)]() mutable {
     120        createOfferTask(*protectedOptions, protectedPromise);
    141121    });
    142122}
Note: See TracChangeset for help on using the changeset viewer.